From boris.kvartskhava at oracle.com Wed Feb 10 17:15:09 2016 From: boris.kvartskhava at oracle.com (boris kvartskhava) Date: Wed, 10 Feb 2016 20:15:09 +0300 Subject: RFR: DIO-11 /src/se/classes/com/oracle/dio/registry/RegistryImpl.java does not compile Message-ID: <56BB701D.2030506@oracle.com> issue: https://bugs.openjdk.java.net/browse/DIO-11 webrev: http://cr.openjdk.java.net/~onazarkina/DIO-11/ Added "final" modifier to local variable "path", now the code is compilable. From snazarkin at azul.com Wed Feb 10 17:19:49 2016 From: snazarkin at azul.com (Sergey Nazarkin) Date: Wed, 10 Feb 2016 17:19:49 +0000 Subject: RFR: DIO-11 /src/se/classes/com/oracle/dio/registry/RegistryImpl.java does not compile In-Reply-To: <56BB701D.2030506@oracle.com> References: <56BB701D.2030506@oracle.com> Message-ID: <0D6E6C36-2ED6-4D04-B5D2-4B3D50677EF4@azul.com> Looks good to me Sergey Nazarkin > On 10 Feb 2016, at 20:15, boris kvartskhava wrote: > > issue: https://bugs.openjdk.java.net/browse/DIO-11 > webrev: http://cr.openjdk.java.net/~onazarkina/DIO-11/ > > Added "final" modifier to local variable "path", now the code is compilable. From boris.kvartskhava at oracle.com Wed Feb 10 17:27:11 2016 From: boris.kvartskhava at oracle.com (boris kvartskhava) Date: Wed, 10 Feb 2016 20:27:11 +0300 Subject: RFR: DIO-12 [I2C] 10-bit i2c addressing is not supported Message-ID: <56BB72EF.5030105@oracle.com> issue: https://bugs.openjdk.java.net/browse/DIO-12 webrev: http://cr.openjdk.java.net/~onazarkina/DIO-12/ This change is adding combined i2c transactions support, actuay (https://bugs.openjdk.java.net/browse/DIO-10) and resoves a number of related issues that reveal on the fix applied: https://bugs.openjdk.java.net/browse/DIO-10 [I2C] Impl combined message support for Linux https://bugs.openjdk.java.net/browse/DIO-13 [I2C] wrong handling of clock frequency https://bugs.openjdk.java.net/browse/DIO-14 [I2C] impossible to communicate to two slaves simultaneously (raspberry pi) https://bugs.openjdk.java.net/browse/DIO-15 Unable to simply skip some bytes. Fix design notes: unlike of SPI where SPIDevice does not have semantic dependencies on SPICompositeMessage-s, I2CDevice encapsulates the notions under I2CCombinedMessage. Thus, the fix with delayed buffers' data synchronization can legally affect both I2CDevice and I2CCombinedMessage. From olga.milovskaya at oracle.com Thu Feb 11 10:23:52 2016 From: olga.milovskaya at oracle.com (olga.milovskaya at oracle.com) Date: Thu, 11 Feb 2016 10:23:52 +0000 Subject: hg: dio/dev: DIO-11:/src/se/classes/com/oracle/dio/registry/RegistryImpl.java does not compile Message-ID: <201602111023.u1BANqGw020465@aojmv0008.oracle.com> Changeset: 2ebc0471aa02 Author: onazarkina Date: 2016-02-11 13:23 +0300 URL: http://hg.openjdk.java.net/dio/dev/rev/2ebc0471aa02 DIO-11:/src/se/classes/com/oracle/dio/registry/RegistryImpl.java does not compile Summary: DIO-11: Added "final" modifier to local variable "path", now the code is compilable. Reviewed-by:snazarki Contributed-by:bkvartsk ! src/se/classes/com/oracle/dio/registry/RegistryImpl.java From olga.milovskaya at oracle.com Mon Feb 29 16:06:26 2016 From: olga.milovskaya at oracle.com (olga.milovskaya at oracle.com) Date: Mon, 29 Feb 2016 16:06:26 +0000 Subject: hg: dio/dev: DIO-10:[I2C] Impl combined message support for Linux Message-ID: <201602291606.u1TG6Qd3028704@aojmv0008.oracle.com> Changeset: ad12ae44e850 Author: onazarkina Date: 2016-02-29 19:06 +0300 URL: http://hg.openjdk.java.net/dio/dev/rev/ad12ae44e850 DIO-10:[I2C] Impl combined message support for Linux Summary: This change is adding combined i2c transactions support and resoves a number of related issues that revealed on the fix applied: https://bugs.openjdk.java.net/browse/DIO-10 [I2C] Impl combined message support for Linux https://bugs.openjdk.java.net/browse/DIO-12 [I2C] 10-bit i2c addressing is not supported https://bugs.openjdk.java.net/browse/DIO-13 [I2C] wrong handling of clock frequency https://bugs.openjdk.java.net/browse/DIO-14 [I2C] impossible to communicate to two slaves simultaneously (raspberry pi) https://bugs.openjdk.java.net/browse/DIO-15 Unable to simply skip some bytes. Unable to simply skip some bytes. Reviewed-by:snazarki Contributed-by:bkvartsk ! src/share/classes/com/oracle/dio/i2cbus/impl/I2CCombinedMessage.java ! src/share/classes/com/oracle/dio/i2cbus/impl/I2CSlaveImpl.java ! src/share/linux/native/com/oracle/dio/i2c/i2c.c