[PATCH] jstaptest.pl: Expect non-zero value for hotspot.jni.NewObjectA.return

Mark Wielaard mjw at redhat.com
Mon Aug 6 08:20:53 PDT 2012

Hi Jon,

While testing the tapset-jstack support I kept getting one failure
for the tapset-probe tests. hotspot.jni.NewObjectA.return is expecting
to get a zero return value. But that doesn't make sense to me since
it would only return zero on failure, and the test program does seem
to want the call to succeed. The similar hotspot.jni.NewObject.return
and hotspot.jni.NewObjectV.return do expect a non-zero return. So I
changed hotspot.jni.NewObjectA.return to expect the same.

I don't know why I hadn't noticed this before. Maybe because this
systemtap bug could occasionally get something wrong and I never
investigated deeply before?

Anyway, with this in place make check-tapset gets a perfect score
each and every time. Does it look sane?



 ChangeLog                |  5 +++++
 test/tapset/jstaptest.pl |  2 +-
 2 files changed, 6 insertions(+), 1 deletions(-)

# HG changeset patch
# User Mark Wielaard <mark at klomp.org>
# Date 1344265949 -7200
# Node ID 6778b5d4054fdb785be032e040628a2c44d35840
# Parent  1f10b1387e48d2582b9f12a0b0f3496fc83d4c36
test/tapset/jstaptest.pl: Expect non-zero value for NewObjectA.return.

diff --git a/ChangeLog b/ChangeLog
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2012-08-06  Mark Wielaard  <mjw at redhat.com>
+	* test/tapset/jstaptest.pl (probestrings): Expect non-zero value
+	for hotspot.jni.NewObjectA.return.
 2012-08-03  Mark Wielaard  <mjw at redhat.com>
 	* Makefile.am (check-tapset-probes): New target.
diff --git a/test/tapset/jstaptest.pl b/test/tapset/jstaptest.pl
--- a/test/tapset/jstaptest.pl
+++ b/test/tapset/jstaptest.pl
@@ -414,7 +414,7 @@
     ["hotspot.jni.NewLongArray", "\"%slen=%d\\n\",name,length", "NewLongArraylen=5"],
     ["hotspot.jni.NewLongArray.return", "\"%sret=%d\\n\",name,ret", "NewLongArrayret=[^0]"],
     ["hotspot.jni.NewObjectA", "\"%s\\n\",name", "NewObjectA"],
-    ["hotspot.jni.NewObjectA.return", "\"%sret=%d\\n\",name,ret", "NewObjectAret=0"],
+    ["hotspot.jni.NewObjectA.return", "\"%sret=%d\\n\",name,ret", "NewObjectAret=[^0]"],
     ["hotspot.jni.NewObjectArray", "\"%slen=%dinit=%d\\n\",name,length,initial", "NewObjectArraylen=5init=0"],
     ["hotspot.jni.NewObjectArray.return", "\"%sret=%d\\n\",name,ret", "NewObjectArrayret=[^0]"],
     ["hotspot.jni.NewObject", "\"%s\\n\",name", "NewObject"],

More information about the distro-pkg-dev mailing list