[rfc][icedtea-web] fixing failing unittests CodeBaseClassLoaderTest.java

Omair Majid omajid at redhat.com
Fri Aug 24 13:14:44 PDT 2012


Hi Deepak,

* Deepak Bhole <dbhole at redhat.com> [2012-08-24 16:05]:
> * Jiri Vanek <jvanek at redhat.com> [2012-08-10 05:24]:
> > On 08/09/2012 03:29 PM, Deepak Bhole wrote:
> > >* Jiri Vanek <jvanek at redhat.com> [2012-08-09 07:30]:
> 
> 
> > +
> > +        assertTrue(timeOnSecondTry < (timeOnFirstTry / 10));
> 
> These checks for 1/10th of the time seem arbitrary. Couldn't it lead to
> intermittent failures?
> 

Possibly, but when I originally wrote this test, the difference between
grabbing the data from the network and using a cached copy was a few
orders of magnitude (it might have been 100 or possibly more). 10
should be perfectly fine for most cases, but we can tweak the value
later if we have to.

Cheers,
Omair



More information about the distro-pkg-dev mailing list