RFC: forward-port pulse-java fixes from icedtea6 to icedtea7

[Andrew Hughes]

----- Original Message -----
> On 02/22/2012 09:08 AM, Andrew Hughes wrote:
> > ----- Original Message -----
> >> Hi,
> >>
> >> The attached patch forward-ports a number of fixes that are
> >> present
> >> in
> >> pulse-java in icedtea6 to icedtea7 (HEAD). I ran through most of
> >> the
> >> pulse-java tests and nothing seems to have regressed.
> >>
> >> One of these fixes should take care of PR875 too: the just-built
> >> pulse-java is used as bootclasspath when generating headers
> >> (though I
> >> havent actually tested it myself).
> >>
> > 
> > Yes, these should have gone in a long time ago and is another issue
> > with working going to 6 and not 7 (or 8).  Thanks for doing this.
> > 
> 
> No problem :)
> 
> >> Shall I push this to icedtea8 as well?
> >>
> > 
> > Please do.
> > 
> 
> I will test this out later today - the patches will probably require
> some tweaking. Do you have any ideas on how you plan to maintain the
> icedtea8 forest/repo? I recall that before OpenJDK7 was released, you
> would periodically merge (is 'merge' the right word here?) the
> IcedTea6
> changes into IcedTea7. Do you plan to do something similar here. Or
> should we try to add fixes to all repositories/release branches?

I've not been able to do that with 7 for some time; not since Lillian
left and I basically ended up taking on 6 too.  It's pretty much impossible
to do a simple merge because of the changes between 7 & 6, so it means
having to cherry pick individual changesets.

Things would work far better if people were proactive and put their
fixes in everywhere that seems appropriate at the start (including
release branches).  This is why I raised the issue in the other thread
about pushing to 7 first.  Ideally, all patches should go 8->7->6 but
I admit that 8 has just not had enough work to be ready for this yet.

Having me do all the forwardporting to 7 & 8 simply doesn't scale.

> 
> >> I am not sure if I want to change the dates in the changelog
> >> entries
> >> from the original. Does anyone have strong feelings either way?
> >>
> > 
> > Don't change the ChangeLog entries.  If you've had to do additional
> > work
> > only on that version, add an additional entry with the current
> > date.
> > This is what I did with e.g. your security patches when backporting
> > them.
> > 
> 
> I did massage the patches enough so they would apply to IcedTea7, but
> I
> don't think I changed what the end result of applying the series of
> patches was. I will post another patch to update NEWS and do some
> cleanup later.
> 
> I have pushed the changesets.

Thanks; I didn't realise there were so many.  Many thanks for picking up on
all these.  Kind of disappointing it's got this bad.

> 
> Cheers,
> Omair
> 

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07