[icedtea-web] RFC: Fix for bug introduced by PR820

[Deepak Bhole]

Hi,

This is a minor fix for a logic error in the PR820 patch I committed
earlier today.

The error was not detectable in any of the live connect tests but a
misbehaving applet (who's javascript call fails) exposed it.

OK for 1.1, 1.2 and HEAD?

Thanks,
Deepak
-------------- next part --------------
diff -r 07717ba83e5f plugin/icedteanp/IcedTeaPluginRequestProcessor.cc
--- a/plugin/icedteanp/IcedTeaPluginRequestProcessor.cc	Mon Feb 27 22:04:05 2012 +0100
+++ b/plugin/icedteanp/IcedTeaPluginRequestProcessor.cc	Mon Feb 27 16:47:35 2012 -0500
@@ -862,8 +862,12 @@
         {
             eval_variant_str = "0";
         }
-        ((AsyncCallThreadData*) data)->result.append(eval_variant_str);
+    } else
+    {
+        eval_variant_str = "0";
     }
+
+    ((AsyncCallThreadData*) data)->result.append(eval_variant_str);
     ((AsyncCallThreadData*) data)->result_ready = true;
 
     PLUGIN_DEBUG("_eval returning\n");
@@ -914,10 +918,12 @@
         {
         	call_result_ptr_str = "0";
         }
-
-        ((AsyncCallThreadData*) data)->result.append(call_result_ptr_str);
+    } else
+    {
+        call_result_ptr_str = "0";
     }
 
+    ((AsyncCallThreadData*) data)->result.append(call_result_ptr_str);
     ((AsyncCallThreadData*) data)->result_ready = true;
 
     PLUGIN_DEBUG("_call returning\n");