RFC: fix problems in jforex charts

Deepak Bhole dbhole at redhat.com
Tue Feb 28 08:50:11 PST 2012


* Omair Majid <omajid at redhat.com> [2012-02-28 11:47]:
> On 02/28/2012 03:07 AM, Jiri Vanek wrote:
> > On 02/27/2012 10:02 PM, Omair Majid wrote:
> >> Hi,
...
...
> >>
> > 
> > But what I'm really wondering  about is comparing of Strings by == / !=
> > ...(!!)... There should be used  equals(...)! Or is it some
> > plugin-java-c bridge featture?
> > Also, when we do not this method to throw an exception, maybe also
> > possible exception thrown by Integer.parseInt(args[3]) should be cought?
> > Both cases ( length<3 and possible caught parsing of number) should go
> > out in  debug mode.
> > 
> > I do not insists   on above points, but I'm throwing them out for
> > discussion.
> > 
> 
> That's a good point. I didn't want to change existing code, but this
> looks prone to failure if the strings are not interned. There are more
> instances of this in icedtea-web too. I will try and post a separate
> patch to address this.
> 

Agreed. This is a separate issue, but one that needs to be addressed.

Deepak



More information about the distro-pkg-dev mailing list