[rfc][icedtea-web] known to fail annotation

[Omair Majid]

On 06/05/2012 10:17 AM, Jiri Vanek wrote:
> On 06/05/2012 02:51 PM, Jiri Vanek wrote:
>> On 06/04/2012 09:53 PM, Omair Majid wrote:
>>> On 05/23/2012 10:59 AM, Jiri Vanek wrote:
>>>> On 05/22/2012 07:30 PM, Omair Majid wrote:
>>>>> On 05/22/2012 08:56 AM, Jiri Vanek wrote:
>>>>>> As agreed on IRC, Percentage removed. What do you think now?
>> ...snip ..
>>>> diff -r 1088b2dffe49 tests/junit-runner/LessVerboseTextListener.java
>>>> --- a/tests/junit-runner/LessVerboseTextListener.java Tue May 22
>>>> 12:08:17 2012 +0200
>>>> +++ b/tests/junit-runner/LessVerboseTextListener.java Wed May 23
>>>> 16:41:21 2012 +0200
>>>
>>>> @@ -45,7 +60,56 @@
>>>> int passed = result.getRunCount() - result.getFailureCount() -
>>>> result.getIgnoreCount();
>>>> int failed = result.getFailureCount();
>>>> int ignored = result.getIgnoreCount();
>>>> - writer.println("Test results: passed: " + passed + "; failed: " +
>>>> failed + "; ignored: " + ignored);
>>>> + writer.println("Test known to fail ("+totalK2F+"): passed: " +
>>>> passedK2F + "; failed: " + failedK2F + "; ignored: " + ignoredK2F);
>>>> + writer.println("Test results ("+result.getRunCount()+"): passed: "
>>>> + passed + "; failed: " + failed + "; ignored: " + ignored);
>>>> + }
>>
>>
>> Do you mind to have total/totalKnownToFail line here? So the three
>> lines will be
>>
>> total
>> know to fail sumary
>> unchanged last line as you wanted
>>
>> =~
>>
>> writer.println("Total tests "+result.getRunCount()+"/ known to fail
>> tests "+totalK2F);
>> writer.println("Test known to fail: passed: " + passedK2F + "; failed:
>> " + failedK2F + "; ignored: " + ignoredK2F);
>> writer.println("Test results: passed: " + passed + "; failed: " +
>> failed + "; ignored: " + ignored);
>>

Looks fine to me. But please check that buildbots on
icedtea.classpath.org can parse (or post a patch to fix them too).

Cheers,
Omair