[RFC][icedtea-web]: Configure browser paths

[Omair Majid]

Hi Saad,

On 06/05/2012 11:11 AM, Saad Mohammad wrote:
> I have attached the patch with all the suggested changes.
> 
> 
> Thanks for the review Omair.

Some comments (nits, really) below.

> +
> +dnl REQUIRED Parameters: 
> +dnl [browser name, variable to store path, terminal command to run browser (if installed), otherwise use the browser name]

A one-line summary of what this does would be nice to have.

> +   if test $# -gt 2; then
> +    AC_PATH_TOOL([$2], [$3], [], [$PATH])  
> +   else
> +    AC_PATH_TOOL([$2], [$1], [], [$PATH])

I believe you can leave out the $PATH argument.

> +   fi
> +  else
> +   AC_MSG_CHECKING([for $1])        
> +   AC_MSG_RESULT([no])
> +  fi

I wish there was a way to have fewer places doing an AC_MSG_CHECKING. If
you can find a way, that would be great. Otherwise it's fine as it is.

Please commit this after fixing the two nits above.

Thanks,
Omair