[rfc] [icedtea-web] handle ignored tests in xml and html outputs correctly
Danesh Dadachanji
ddadacha at redhat.com
Mon Jun 11 07:43:06 PDT 2012
On 11/06/12 05:13 AM, Jiri Vanek wrote:
> Although "test was ignored" reaches outputs correctly, and also ignored tests are counted correctly, somehow slipped through my
> fingers to mark also exact tests as ignored (when should be;) although styles exists . This patch is fixing this.
>
> * tests/junit-runner/JunitLikeXmlOutputListener.java:
> Introduced TEST_IGNORED_ATTRIBUTE to mark test as ignored if should be.
> * tests/report-styles/jreport.xsl: Applied correct text and style for
> tests with attribute ignored.
>
>
Looks good to me. The last hunk's indentation looks a bit inconsistent, if you have a second before commiting, please fix it. Feel free
to push to HEAD!
Cheers,
Danesh
Hunk in question:
@@ -246,8 +249,15 @@
<xsl:choose>
<xsl:when test="not(error)">
<div class="status">
- PASSED (<xsl:value-of select="@time"/>s)
- <xsl:choose>
+ <xsl:choose>
+ <xsl:when test="@ignored">
+ IGNORED (<xsl:value-of select="@time"/>s)
+ </xsl:when>
+ <xsl:otherwise>
+ PASSED (<xsl:value-of select="@time"/>s)
+ </xsl:otherwise>
+ </xsl:choose>
+ <xsl:choose>
<xsl:when test="@known-to-fail">
<xsl:choose>
<xsl:when test="@known-to-fail=true">
More information about the distro-pkg-dev
mailing list