[RFC][icedtea-web] Test for regression of ServiceManager not setup correctly

[Danesh Dadachanji]

On 13/06/12 10:28 AM, Jiri Vanek wrote:
> On 06/08/2012 11:43 PM, Danesh Dadachanji wrote:
>> On 20/04/12 04:05 AM, Jiri Vanek wrote:
>>>>>>> In general, am not sure how good these applet tests might be. We know
>>>>>>> that applets run under javaws use different code paths from applets run
>>>>>>> under a browser. Still it's better to have a few tests than none.
>>>>>>
>>>>> As mentioned above in-html tests will be necessary to be added when
>>>>> browser-testing will be pushed.
>>>>>
>>>>
>>>> Will do.
>>>>
>>>>>
>>>>>
>>>
>>>
>>> Just reminder O:)
>>
>> I had it on my TODO list =)
>>
>> What do you think of the attached patch? It adds the test, refactors CheckServices into a helper
>> method and adds the @NeedsDisplay annotations.
>>
>> ChangeLog:
>> +2012-06-08  Danesh Dadachanji <ddadacha at redhat.com>
>> +
>> +    Update CheckServices reproducer to handle browser testcase.
>> +    * tests/jnlp_tests/simple/CheckServices/testcases/CheckServicesTests.java:
>> +    Added browser test and annotation, refactored asserts into helper method.
>> +    * tests/jnlp_tests/simple/CheckServices/resources/CheckPluginServices.html:
>> +    New browser test file that runs applet using jnlp_href.
>> +
>>
>> Okay for HEAD?
>
> Looks ok. Just two minors lower, feel free to push after fix.
>
> End ensure it compiles;)
>

Thanks for the review! Pushed after both the changes:

http://icedtea.classpath.org/hg/icedtea-web/rev/2c788a60aa65