[RFC][icedtea-web]: Fix for PR1040, PR1041, PR1042 w/ reproducers

[Saad Mohammad]

On 06/20/2012 07:06 AM, Jiri Vanek wrote:
> On 06/18/2012 10:52 PM, Saad Mohammad wrote:
>> The attached patch resolves PR1040, PR1041, PR1042:
>> http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1040
>> http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1041
>> http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1042
>>
> Can you pplease split this to 6 separate patches? 3reproducers and three
> fixes?
> Imho 1041 is not a bug..but others can have different opinion.
> But reproducer is worthy for it - its failure will be then considered as
> "passed" (NOT @knowntofail)
>
> One global thing - there is Bug annotation for tests, please fill it.
>
>
> Thanx for looking into it, J.

Hi Jiri,

Thank you for looking into my patch. Unfortunately because all three 
bugs are closely related to each other, I am unable to split the patch 
up into 3 different ones. However, if you'd like, it is possible to 
split this up into two different patches - PR1040 patch and a patch for 
PR1041. The reason why I am trying to avoid splitting the patch up is 
because the fix for PR1041 also resolves PR1042 but then PR1040 patch 
will depend on the PR1041 fix. Please let me know if you'd still prefer 
a patch like that.

As for the reproducers, I added the Bug annotation like you have 
suggested. The reproducers for all three bugs are in one testcase and 
are sharing the same resources. If I was to split up the reproducers, I 
would, again, have multiple patches depending on each other. So I am 
trying to avoid splitting this up.

I have split the current patch into three different ones and have 
attached it in this email for review:
       1) PR1040, PR1041, PR1042 fix
       2) Reproducers that tests all three bugs
       3) Changelog entry

Also please leave additional comments for PR1041 on 
http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1041. Deepak 
suggests we treat this as a bug to avoid 'compatibility' problems.

Thanks again! :)
-- 
Cheers,
Saad Mohammad


-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix01.patch
Type: text/x-patch
Size: 6778 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20120620/8259c85d/fix01.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: reproducers02.patch
Type: text/x-patch
Size: 42747 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20120620/8259c85d/reproducers02.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: changelog01.patch
Type: text/x-patch
Size: 2989 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20120620/8259c85d/changelog01.patch