[RFC][icedtea-web]: Fix for PR1040, PR1041, PR1042 w/ reproducers

[Saad Mohammad]

On 06/27/2012 04:36 PM, Adam Domurad wrote:
> 1) You have changed the behaviour of JNLPClassLoader here by making the
> constructor private instead of protected, prohibiting subclassing.
Didn't realize I did that. Fixed.
>
> 2) You did not need to introduce a method 'initializeJNLPClassLoader'.
> What you do in this scenario:
> - Have JNLPClassLoader(JNLPFile file, UpdatePolicy policy, String
> mainName) with the full implementation
> - call 'this(file, policy, null);' in JNLPClassLoader(JNLPFile file,
> UpdatePolicy policy). This will call the other constructor without the
> need for a separate initalize procedure.
Doh, I didn't know it was possible to call a constructor from another 
constructor. Anyways, thanks for the tips. The new patch is attached. :)
I also removed mainClass.equal("") check in the if condition like you 
suggested.

-- 
Cheers,
Saad Mohammad

-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix06.patch
Type: text/x-patch
Size: 8671 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20120627/db667b87/fix06.patch