[icedtea-web][rfc] Fix for PR1011 w/ reproducer

Jiri Vanek jvanek at redhat.com
Thu Jun 28 06:57:01 PDT 2012


On 06/27/2012 09:50 PM, Adam Domurad wrote:
> So finally I got the custom makefile system working with my reproducer,
> with many thanks to Jiri.
>
> This reproducer&  patch addresses the issue that folders may be included
> in archive tags as well as jars.
>
> Note this patch was already posted with a review from Pavel and only
> requires an OK for head. Included is minor refactoring that was done
> during the patch, that needs a separate review.
>
> Changelog for bugfix:
> 2012-05-29  Adam Domurad<adomurad at redhat.com>
>
> 	Allow for folders in archive tag.	
> 	* netx/net/sourceforge/jnlp/PluginBridge.java:
> 	(PluginBridge) Changes jar ->  archive, parse contents with
> 	addArchiveEntries.
> 	(addArchiveEntries) New method. Adds entries ending with / to the list
> 	of folders.
> 	(getCodeBaseFolders) Returns the folders collected by addArchiveEntries
> 	* netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java:
> 	(initializeResources) If ran as plugin, add archive tag folders to the
> 	code base loader.
>
>
> Changelog for reproducers:
> 2012-06-27  Adam Domurad<adomurad at redhat.com>
>
> 	Tests folders in archive tag
> 	*
> tests/jnlp_tests/custom/AppletFolderInArchiveTag/testcases/AppletFolderInArchiveTagTests.java: Runs html file in browser
> 	* tests/jnlp_tests/custom/AppletFolderInArchiveTag/srcs/Makefile:
> 	packages compiled source files in folder
> 	*
> tests/jnlp_tests/custom/AppletFolderInArchiveTag/srcs/AppletFolderInArchiveTag.java:
> 	Simple output to confirm it is running
> 	*
> tests/jnlp_tests/custom/AppletFolderInArchiveTag/resources/AppletFolderInArchiveTag.html:
> 	Has folder in its archive tag that contains a class file
>
>

I'm ok with reproducere. Just please add some text to index.html you arte generating
eg <html>Mbody><h1>this was causing zip exception</h1.../...>
After this please push reproducer to head.

J.




More information about the distro-pkg-dev mailing list