[rfc][icedtea-web] a new reproducer for LiveConnect J->JS "get" tests

Jana Fabrikova jfabriko at redhat.com
Thu Apr 11 05:58:22 PDT 2013

Hi Adam,

On Wed, 2013-03-06 at 12:50 -0500, Adam Domurad wrote:
> This isn't what your subject line says it is :-)
you are right, this was an exceptional time when all the reproducers
were a little bit simillar and I tried to send them at once, which was
not such a good idea, since I forgot to change the subject;)

> On 03/06/2013 10:58 AM, Jana Fabrikova wrote:
> > Hello,
> >
> > please see the attached patch of new reproducer for J->JS "evaluating 
> > by calling JS eval from J".
> The patch itself looks good, but what was the motivation for this ? IMHO 
> we do not need more than one reproducer that tests eval, which we 
> already have (JSObjectFromEval). From our point-of-view it's sending a 
> string to the javascript engine. All the specific object conversion 
> stuff should be handled with unit tests (this may require a bit of 
> refactoring to support, but should be do-able).

Ok, I will not push this reproducer, since the sending of string to JS
eval is already covered by JSObjectFromEval.

Thank you for the review, 

> Are you working on all these patches concurrently ? If not it'd be 
> better to post them to list for feedback as you finish them, instead of 
> all at once. Not a huge deal, though.
>  > [..snip..]
> Happy hacking,
> -Adam

More information about the distro-pkg-dev mailing list