[rfc][icedtea-web] Minor NetxPanel clean-up

Adam Domurad adomurad at redhat.com
Tue Apr 23 07:03:19 PDT 2013

On 04/23/2013 09:43 AM, Jiri Vanek wrote:
> Well I was s unable to verify that this change is correct, so I have 
> tried to find why it should be wrong.
> And I have found no evil done, so I'm for to push it.
> Jsut one funny thing to expalin maybe (although it is quite obvious 
> from code):
> >     (exitOnFailure): Remove always-false field.
> > -    private boolean exitOnFailure = true;
> > -    public NetxPanel(URL documentURL, PluginParameters params,
> > -                     boolean exitOnFailure) {
> > -        this(documentURL, params);
> > -        this.exitOnFailure = exitOnFailure;
> > -                NetxPanel panel = new NetxPanel(doc, params, false);
> You probably do not know why i was initially added?

No luck here, it was added in commit 0. The history is out there 
probably (from OpenJDK6 tree ?), but I'm not entirely sure how to easily 
get at it :-)
So as far as I can see it only makes sense if there is one Java instance 
per applet.
I can only guess that while originally writing this class, it was 
unclear which route would be taken (single JVM vs multiple JVM), so it 
was made an option.
(We are of course strongly committed to the single-JVM model now, and 
for the best, it allows applets to start quite quickly).
Hope that is somewhat of an answer :-)

Will push, thanks.

> Thanx for clean up
> J.

More information about the distro-pkg-dev mailing list