Reviewer needed: three new JTreg ComponentOrientation-related tests for IcedTea6 HEAD

Jiri Vanek jvanek at redhat.com
Tue Apr 30 04:05:08 PDT 2013


On 04/30/2013 12:03 PM, Pavel Tisnovsky wrote:
> ----- Jiri Vanek <jvanek at redhat.com> wrote:
>> On 04/29/2013 04:38 PM, Pavel Tisnovsky wrote:
>>> Hi everyone,
>>>
>>> I'd like to add three new JTreg tests into IcedTea6 HEAD. These tests
>>> check the basic behavior of ComponentOrientation subsystem (this is part
>>> of IT which is AFAIK not thoroughly tested ATM and new patches/backports
>>> could break this part w/o alerts).
>>>
>>> FYI: I'm also going to ask for inclusion of these three test into
>>> OpenJDK8 HEAD and then backporting them into OpenJDK7 too.
>>>
>>> ChangeLog entry:
>>>
>>> 2013-04-29  Pavel Tisnovsky  <ptisnovs at redhat.com>
>>>
>>> 	* Makefile.am:
>>> 	(ICEDTEA_PATCHES): Added new patch.
>>> 	* patches/componentOrientationTests.patch:
>>> 	Three JTreg tests for checking ComponentOrientation subsystem behaviour.
>>>
>>>
>>> Can anybody please review this change?
>>>
>>> Thank you in advance,
>>> Pavel Tisnovsky
>>>
>>
>> Hi!
>> Maybe more detailed changelog (taking care of all three files in the patch may be worthy)
>> Although all three files compile fine, they never stops when running from commandline.
>> I suspect swing thread is keep running.
>> Can you please fix it?
>>
>
> Hi Jiri,
>
> you are right that there should be problem when tests are started directly from CLI and not indirectly
> using JTreg tool. I've fixed all three tests and checked if it works correctly. I've also changed
> one test to work correctly in Gnome Shell and similar "modern" desktop environments :-)
>
> New ChangeLog entry:
>
> 2013-04-30  Pavel Tisnovsky  <ptisnovs at redhat.com>
>
> 	* Makefile.am:
> 	(ICEDTEA_PATCHES): Added new patch.
> 	* patches/componentOrientationTests.patch:
> 	Patch containing three new JTreg tests ComponentOrientationTest.java,
> 	ComponentPlacementTest.java and ComponentSizeTest.java. These tests
> 	check if ComponentOrientation subsystem behaviour is correct even
> 	when right-to-left orientation is used.
>
> Ok now?

ok now :)
>
> Cheers,
> Pavel
>
>>
>> java version "1.7.0_19"
>> OpenJDK Runtime Environment (fedora-2.3.9.3.fc18-x86_64)
>> OpenJDK 64-Bit Server VM (build 23.7-b01, mixed mode)
>>
>> J.
>>
>




More information about the distro-pkg-dev mailing list