[rfc][icedtea-web] Removing applications tab in jawas-about

Jiri Vanek jvanek at redhat.com
Wed Jul 10 09:35:30 PDT 2013


On 07/10/2013 04:15 PM, Andrew Azores wrote:
> On 07/09/2013 01:28 PM, Andrew Azores wrote:
>> On 07/09/2013 12:23 PM, Andrew Azores wrote:
>>> On 07/09/2013 11:46 AM, Andrew Azores wrote:
>>>> Changelog:
>>>> * Makefile.am (stamps/netx-html-gen): removed logic for extras.jar, added new stamp to create
>>>> HTML for AboutDialog
>>>> * netx/net/sourceforge/jnlp/about/AboutDialog.java: Moved out of extras into netx and renamed
>>>> from Main. New Swing layout and uses HTML files generated in Makefile.
>>>> * netx/net/sourceforge/jnlp/about/HTMLPanel.java: Moved out of extras into netx. Added ability
>>>> to click hyperlinks.
>>>> * netx/net/sourceforge/jnlp/runtime/Boot.java (main, getAboutFile, getJNLPFile, itwInfoMessage):
>>>> changed way of launching About dialog to using new static display method rather than JNLP
>>>> launch. Removed methods relating to JNLP launch. More informative and nicely formatted -headless
>>>> information.
>>>>
>>>> * netx/net/sourceforge/jnlp/resources/Messages.properties (BAboutITW, BFileInfoAuthors,
>>>> BFileInfoCopying, BFileInfoNews): added new messages for javaws -about -headless launch
>>>> * netx/net/sourceforge/jnlp/resources/about.html: moved out of extras into netx. Added more
>>>> content, changed formatting.
>>>> * netx/net/sourceforge/jnlp/resources/about.jnlp: removed, no longer needed
>>>> * netx/net/sourceforge/jnlp/resources/itw_logo.png: new image for About dialog. Modified version
>>>> of javaws_splash.png
>>>> * netx/net/sourceforge/jnlp/resources/jamIcon.jpg: moved out of extras into netx
>>>>
>>>> * extra/net/sourceforge/javaws/about/HTMLPanel.java: moved into netx
>>>> * extra/net/sourceforge/javaws/about/Main.java: same
>>>> * extra/net/sourceforge/javaws/about/resources/about.html: same
>>>> * extra/net/sourceforge/javaws/about/resources/jamIcon.jpg: same
>>>> * extra/net/sourceforge/javaws/about/resources/applications.html: removed
>>>> * extra/net/sourceforge/javaws/about/resources/notes.html: removed
>>>
>>> And here is the new itw_logo.png.
>>>
>>> Andrew A
>>>
>> Updated patches so that the button labels in the AboutDialog are localized.
>>
>> Andrew A
> Everything all together in one big patch file as per request.
>
> Andrew A

Hi!

Pushed[1]

Few nits
  -  I have added prefix to you properties keys
  - fixed by accident dirty netx-dist-tests-whitelist
  - you have been added to AUTHORS

well news file should be updated.... I will do this with one minor About improvement.


This was huge commit. Please double chek I did it correctly (clone, build verify commit message and 
my push diff and whatever cross your mind)


Nice work!

Thank you
   J.

[1] http://icedtea.classpath.org/hg/icedtea-web/rev/c806308b6529



More information about the distro-pkg-dev mailing list