[rfc][icedtea-web] New PartiallySigned Dialog
Andrew Azores
aazores at redhat.com
Tue Mar 4 14:07:09 PST 2014
Hi,
This patch introduces a new PartiallySigned dialog to replace the
NotAllSigned prompt. This new dialog uses the same abstracted parent
class that was pulled out of the Unsigned dialog, so it uses the same
remembered action storage and has the same general look and feel. This
dialog also has a Sandbox button, just like CertWarningPane recently
gained for fully signed applets, which allows partially signed ones to
also be run with only sandbox permissions. Some more security info is
also present on the dialog, eg the applet's publisher and codebase. Not
yet included is a new Help text for this dialog, but this can be written
up separately IMO. Right now it will just display the same Help as the
Unsigned dialog.
ChangeLog:
Added new PartiallySigned Dialog to replace NotAllSignedWarningPane.
Also includes a Sandbox button.
* netx/net/sourceforge/jnlp/resources/Messages.properties:
(APPEXTSecunsignedAppletActionSandbox, LPartiallySignedApplet,
LPartiallySignedAppletUserDenied) new messages
* netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java:
Logic added for displaying new PartiallySigned dialog.
(showNotAllSignedDialog) removed. (getSigningState) new method.
(promptUserOnPartialSigning, userPromptedForPartialSigning) new methods for
SecurityDelegate.
* netx/net/sourceforge/jnlp/security/AppTrustWarningDialog.java:
(partiallySigned) new method
* netx/net/sourceforge/jnlp/security/AppTrustWarningPanel.java:
(chosenActionSetter) refactored to allow Sandbox action.
(setupInfoPanel) applet
title made overrideable by subclasses
* netx/net/sourceforge/jnlp/security/SecurityDialog.java:
(NOTALLSIGNED_WARNING)
renamed PARTIALLYSIGNED_WARNING, display new dialog rather than old
* netx/net/sourceforge/jnlp/security/SecurityDialogs.java:
(NOTALLSIGNED_WARNING)
renamed PARTIALLYSIGNED_WARNING. (showNotAllSignedWarningDialog) removed.
(showPartiallySignedWarningDialog) new method
*
netx/net/sourceforge/jnlp/security/appletextendedsecurity/ExecuteAppletAction.java:
Added Sandbox action
*
netx/net/sourceforge/jnlp/security/appletextendedsecurity/UnsignedAppletTrustConfirmation.java:
(checkPartiallySignedWithUserIfRequired) new method
*
tests/reproducers/custom/SignedAppletCodebaseLoading/testcases/SignedAppletCodebaseLoadingTests.java:
test now passes since dialog will not appear if applet security is set
to Low.
KnownToFail removed.
*
tests/reproducers/custom/SignedAppletExternalMainClass/testcases/SignedAppletExternalMainClassTest.java:
same
*
netx/net/sourceforge/jnlp/security/PartiallySignedAppTrustWarningPanel.java:
new class
* netx/net/sourceforge/jnlp/security/NotAllSignedWarningPane.java: deleted
in favour of PartiallySignedAppTrustWarningPanel
Thanks,
--
Andrew A
-------------- next part --------------
A non-text attachment was scrubbed...
Name: partially-signed-dialog.patch
Type: text/x-patch
Size: 36956 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140304/c8201b95/partially-signed-dialog-0001.patch
More information about the distro-pkg-dev
mailing list