[icedtea-web] RFC: Use AC_LANG_SOURCE macros

Omair Majid omajid at redhat.com
Fri Mar 28 17:49:56 UTC 2014


Hi,

I just tried to build a fresh clone of icedtea-web and got a few scary
warnings on running autogen.sh:

  configure.ac:89: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE call detected in body
  ../../lib/autoconf/lang.m4:193: AC_LANG_CONFTEST is expanded from...
  ../../lib/autoconf/general.m4:2590: _AC_COMPILE_IFELSE is expanded from...
  ../../lib/autoconf/general.m4:2606: AC_COMPILE_IFELSE is expanded from...
  acinclude.m4:523: IT_CHECK_XULRUNNER_MIMEDESCRIPTION_CONSTCHAR is expanded from...
  configure.ac:89: the top level

The attached patch fixes the warning by wrapping the code in an
AC_LANG_SOURCE macro.

Thanks,
Omair

-- 
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681
-------------- next part --------------
diff --git a/ChangeLog b/ChangeLog
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2014-03-28  Omair Majid  <omajid at redhat.com>
+
+	* acinclude.m4
+	(IT_CHECK_XULRUNNER_MIMEDESCRIPTION_CONSTCHAR),
+	(IT_CHECK_XULRUNNER_REQUIRES_C11): Use AC_LANG_SOURCE with code.
+
 2014-03-27  Andrew Azores  <aazores at redhat.com>
 
 	Fix NPE when trying to open a new file, with changes made, and wanting to
diff --git a/acinclude.m4 b/acinclude.m4
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -527,9 +527,9 @@
   CXXFLAGS_BACKUP="$CXXFLAGS"
   CXXFLAGS="$CXXFLAGS"" ""$MOZILLA_CFLAGS"
   AC_COMPILE_IFELSE([
-    #include <npfunctions.h>]
-    [const  char* NP_GetMIMEDescription ()
-    {return (char*) "yap!";}
+    AC_LANG_SOURCE([[#include <npfunctions.h>
+                     const  char* NP_GetMIMEDescription ()
+                       {return (char*) "yap!";}]])
     ],[
     AC_MSG_RESULT(no)
     ],[
@@ -547,10 +547,10 @@
   CXXFLAGS_BACKUP="$CXXFLAGS"
   CXXFLAGS="$CXXFLAGS"" ""$MOZILLA_CFLAGS"
   AC_COMPILE_IFELSE([
-    #include <npapi.h>
-    #include <npruntime.h>]
-    [void setnpptr (NPVariant *result)
-    {VOID_TO_NPVARIANT(*result);}
+    AC_LANG_SOURCE([[#include <npapi.h>
+                     #include <npruntime.h>
+                     void setnpptr (NPVariant *result)
+                       { VOID_TO_NPVARIANT(*result);}]])
     ],[
     AC_MSG_RESULT(no)
     CXXFLAGS="$CXXFLAGS_BACKUP"


More information about the distro-pkg-dev mailing list