From jwilhelm at openjdk.java.net Tue Sep 1 04:26:31 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Tue, 1 Sep 2020 04:26:31 GMT Subject: RFR: Added JBS Label Dictionary Message-ID: <7vzFOdtXevWQtVYp6uYoywANxYL1jTpjzlXDFpJeGzU=.47686966-7478-4300-a3fc-98a2cd83567f@github.com> Moving the JBS label Dictionary from the OpenJDK wiki into the Guide. Did some updates of the text. I'm guessing this dictionary is missing several labels used by libraries and client since it has a hotspot background. Please let me know what labels to add (or just add them). I also moved the noreg-* description from "Change Planning" into this dictionary as I think it fits better here. All labels have anchors so you can link directly to any label in the dictionary. ------------- Commit messages: - Added JBS Label Dictionary Changes: https://git.openjdk.java.net/guide/pull/26/files Webrev: https://webrevs.openjdk.java.net/?repo=guide&pr=26&range=00 Stats: 616 lines in 3 files changed: 493 ins; 95 del; 28 mod Patch: https://git.openjdk.java.net/guide/pull/26.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/26/head:pull/26 PR: https://git.openjdk.java.net/guide/pull/26 From david.holmes at oracle.com Tue Sep 1 04:49:26 2020 From: david.holmes at oracle.com (David Holmes) Date: Tue, 1 Sep 2020 14:49:26 +1000 Subject: RFR: Added JBS Label Dictionary In-Reply-To: <7vzFOdtXevWQtVYp6uYoywANxYL1jTpjzlXDFpJeGzU=.47686966-7478-4300-a3fc-98a2cd83567f@github.com> References: <7vzFOdtXevWQtVYp6uYoywANxYL1jTpjzlXDFpJeGzU=.47686966-7478-4300-a3fc-98a2cd83567f@github.com> Message-ID: Hi Jesper, How do we actually view this in a readable format? Thanks, David On 1/09/2020 2:26 pm, Jesper Wilhelmsson wrote: > Moving the JBS label Dictionary from the OpenJDK wiki into the Guide. Did some updates of the text. > > I'm guessing this dictionary is missing several labels used by libraries and client since it has a hotspot background. > Please let me know what labels to add (or just add them). > > I also moved the noreg-* description from "Change Planning" into this dictionary as I think it fits better here. All > labels have anchors so you can link directly to any label in the dictionary. > > ------------- > > Commit messages: > - Added JBS Label Dictionary > > Changes: https://git.openjdk.java.net/guide/pull/26/files > Webrev: https://webrevs.openjdk.java.net/?repo=guide&pr=26&range=00 > Stats: 616 lines in 3 files changed: 493 ins; 95 del; 28 mod > Patch: https://git.openjdk.java.net/guide/pull/26.diff > Fetch: git fetch https://git.openjdk.java.net/guide pull/26/head:pull/26 > > PR: https://git.openjdk.java.net/guide/pull/26 > From jwilhelm at openjdk.java.net Tue Sep 1 05:35:13 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Tue, 1 Sep 2020 05:35:13 GMT Subject: RFR: Adding mapping from source to mail list [v2] In-Reply-To: References: Message-ID: <85EFoqYxrZGLXzz_pfXAphUCJ4feogX6n5R7Bh_67eQ=.c360f780-3206-4761-97ba-cf47252ec6f7@github.com> On Fri, 28 Aug 2020 19:40:27 GMT, Iris Clark wrote: >> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: >> >> Updated with Iris' additions > > How much of this is replicated by the similar list which Skara will use to generate the mailing list for pull request > notifications? If the Skara version is expected to be maintained more closely because of use, then perhaps the Guide > should just reference it after it appears in jdk/jdk? On the topic of pr notifications, I think that this mail, > providing details for how the mailing list for pull requests is created and may be modified is Guide-worthy either as a > direct reference or as a copy and modify to handle evolution: > https://mail.openjdk.java.net/pipermail/jdk-dev/2020-August/004677.html Thank you for the review Iris! All additions have been made. As for the file added by Skara I'm not sure how easy that one will be for new developers to access and read. We should definitely mention it once it's in place. One difference with the current list is that I've included directories from older JDK versions as well, it's not only mainline. I'm not sure how Skara will handle older releases in this regard. Anyhow, we can remove/update the list later should it turn out to be duplicated information. > src/codeowners.md line 110: > >> 109: * `libverify` ? >> 110: * `libzip` ? >> 111: * `java.compiler` ? LangTools > > Core Libs Fixed. > src/codeowners.md line 109: > >> 108: * `libosxsecurity` ?? Security >> 109: * `libverify` ? >> 110: * `libzip` ? > > LangTools Fixed. > src/codeowners.md line 101: > >> 100: * `launcher` ? Langtools >> 101: * `libfdlibm` ? >> 102: * `libjava` ? Core Libs > > Core Libs Fixed. > src/codeowners.md line 95: > >> 94: * `lib/security` ? Security >> 95: * `man` ? >> 96: * `native` > > This depends on who owns the tool. I believe that this entry corresponds to this part of the repo: > > https://hg.openjdk.java.net/jdk/jdk/file/ec0cabbc527f/src/java.base/share/man > > I see that there are man pages for java, jfr, and keytool. > > Further down in this list I see that mail for the launcher is being directed to LangTools, so that's where I'd send > changes for the java man page. > Changes to the jdk.jfr module are being sent to Runtime, so that's where changes to the corresponding man page should > be sent. > keytool is owned by Security. Fixed. > src/codeowners.md line 100: > >> 99: * `jspawnhelper` ? LangTools >> 100: * `launcher` ? Langtools >> 101: * `libfdlibm` ? > > "LangTools" instead of "Langtools"? (capitalization) Check for other occurrences. Fixed. > src/codeowners.md line 74: > >> 73: * `java.base` >> 74: * Core Libs should almost always be included but Langtools, HotSpot, and/or Security may also be involved. >> 75: * `classes` > > I18n also owns code in java.base. Fixed. > src/codeowners.md line 87: > >> 86: * `security` ? Security >> 87: * `text` ? Core Libs >> 88: * `time` ? Core Libs > > I18n owns the java.text package. Fixed. ------------- PR: https://git.openjdk.java.net/guide/pull/25 From jwilhelm at openjdk.java.net Tue Sep 1 05:35:11 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Tue, 1 Sep 2020 05:35:11 GMT Subject: RFR: Adding mapping from source to mail list [v2] In-Reply-To: References: Message-ID: > A few directories are still not "owned" by anyone. I'd appreciate any help here. Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: Updated with Iris' additions ------------- Changes: - all: https://git.openjdk.java.net/guide/pull/25/files - new: https://git.openjdk.java.net/guide/pull/25/files/7e0f15dc..9c52db0e Webrevs: - full: https://webrevs.openjdk.java.net/?repo=guide&pr=25&range=01 - incr: https://webrevs.openjdk.java.net/?repo=guide&pr=25&range=00-01 Stats: 13 lines in 1 file changed: 3 ins; 0 del; 10 mod Patch: https://git.openjdk.java.net/guide/pull/25.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/25/head:pull/25 PR: https://git.openjdk.java.net/guide/pull/25 From jesper.wilhelmsson at oracle.com Tue Sep 1 05:41:29 2020 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Tue, 1 Sep 2020 07:41:29 +0200 Subject: RFR: Added JBS Label Dictionary In-Reply-To: References: <7vzFOdtXevWQtVYp6uYoywANxYL1jTpjzlXDFpJeGzU=.47686966-7478-4300-a3fc-98a2cd83567f@github.com> Message-ID: <8CDC0054-58E0-4D3C-87DF-F0A0219D3495@oracle.com> Hi David. I think the easiest way is to pull the branch from the PR and build it locally. There are additional fonts and stylesheets that will be in use once the page hits the webserver, but the local result is good enough to get a sense of the page I think. /Jesper > On 1 Sep 2020, at 06:49, David Holmes wrote: > > Hi Jesper, > > How do we actually view this in a readable format? > > Thanks, > David > > On 1/09/2020 2:26 pm, Jesper Wilhelmsson wrote: >> Moving the JBS label Dictionary from the OpenJDK wiki into the Guide. Did some updates of the text. >> I'm guessing this dictionary is missing several labels used by libraries and client since it has a hotspot background. >> Please let me know what labels to add (or just add them). >> I also moved the noreg-* description from "Change Planning" into this dictionary as I think it fits better here. All >> labels have anchors so you can link directly to any label in the dictionary. >> ------------- >> Commit messages: >> - Added JBS Label Dictionary >> Changes: https://git.openjdk.java.net/guide/pull/26/files >> Webrev: https://webrevs.openjdk.java.net/?repo=guide&pr=26&range=00 >> Stats: 616 lines in 3 files changed: 493 ins; 95 del; 28 mod >> Patch: https://git.openjdk.java.net/guide/pull/26.diff >> Fetch: git fetch https://git.openjdk.java.net/guide pull/26/head:pull/26 >> PR: https://git.openjdk.java.net/guide/pull/26 From david.holmes at oracle.com Tue Sep 1 07:30:28 2020 From: david.holmes at oracle.com (David Holmes) Date: Tue, 1 Sep 2020 17:30:28 +1000 Subject: RFR: Added JBS Label Dictionary In-Reply-To: <8CDC0054-58E0-4D3C-87DF-F0A0219D3495@oracle.com> References: <7vzFOdtXevWQtVYp6uYoywANxYL1jTpjzlXDFpJeGzU=.47686966-7478-4300-a3fc-98a2cd83567f@github.com> <8CDC0054-58E0-4D3C-87DF-F0A0219D3495@oracle.com> Message-ID: <6ed30a8c-cb71-8046-ae39-f02e1b1014c0@oracle.com> On 1/09/2020 3:41 pm, Jesper Wilhelmsson wrote: > Hi David. > > I think the easiest way is to pull the branch from the PR and build it locally. There are additional fonts and stylesheets that will be in use once the page hits the webserver, but the local result is good enough to get a sense of the page I think. Took longer than anticipated due to pandoc issues :) Typo: pahes Does "integration-blocker" have any meaning now? The font/formatting for foo-bar-(Rel) doesn't look good as the "(Rel)" part seems much bigger than the monospaced font used for the foo-bar- part. But that may just be a stylesheet issue with the local view. Otherwise seems okay to me. Thanks, David > > /Jesper > >> On 1 Sep 2020, at 06:49, David Holmes wrote: >> >> Hi Jesper, >> >> How do we actually view this in a readable format? >> >> Thanks, >> David >> >> On 1/09/2020 2:26 pm, Jesper Wilhelmsson wrote: >>> Moving the JBS label Dictionary from the OpenJDK wiki into the Guide. Did some updates of the text. >>> I'm guessing this dictionary is missing several labels used by libraries and client since it has a hotspot background. >>> Please let me know what labels to add (or just add them). >>> I also moved the noreg-* description from "Change Planning" into this dictionary as I think it fits better here. All >>> labels have anchors so you can link directly to any label in the dictionary. >>> ------------- >>> Commit messages: >>> - Added JBS Label Dictionary >>> Changes: https://git.openjdk.java.net/guide/pull/26/files >>> Webrev: https://webrevs.openjdk.java.net/?repo=guide&pr=26&range=00 >>> Stats: 616 lines in 3 files changed: 493 ins; 95 del; 28 mod >>> Patch: https://git.openjdk.java.net/guide/pull/26.diff >>> Fetch: git fetch https://git.openjdk.java.net/guide pull/26/head:pull/26 >>> PR: https://git.openjdk.java.net/guide/pull/26 > From jesper.wilhelmsson at oracle.com Tue Sep 1 11:40:58 2020 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Tue, 1 Sep 2020 13:40:58 +0200 Subject: RFR: Added JBS Label Dictionary In-Reply-To: <6ed30a8c-cb71-8046-ae39-f02e1b1014c0@oracle.com> References: <7vzFOdtXevWQtVYp6uYoywANxYL1jTpjzlXDFpJeGzU=.47686966-7478-4300-a3fc-98a2cd83567f@github.com> <8CDC0054-58E0-4D3C-87DF-F0A0219D3495@oracle.com> <6ed30a8c-cb71-8046-ae39-f02e1b1014c0@oracle.com> Message-ID: > On 1 Sep 2020, at 09:30, David Holmes wrote: > > On 1/09/2020 3:41 pm, Jesper Wilhelmsson wrote: >> Hi David. >> I think the easiest way is to pull the branch from the PR and build it locally. There are additional fonts and stylesheets that will be in use once the page hits the webserver, but the local result is good enough to get a sense of the page I think. > > Took longer than anticipated due to pandoc issues :) Is there anything we can to update in the instructions in the readme to avoid that others run into the same issues? > Typo: pahes Fixed. > Does "integration-blocker" have any meaning now? It can still be used in project repos and the client repo. Don't think anyone actually use it right now though. But I think we will see more shared workspaces as we move to git since it's so much easier to just share a fork or a branch so it may come back :-) > The font/formatting for foo-bar-(Rel) doesn't look good as the "(Rel)" part seems much bigger than the monospaced font used for the foo-bar- part. But that may just be a stylesheet issue with the local view. Yes I see that too. Looking at the final web version of the Guide tt-text has the same size as normal text, so I hope that will look better once published. If not I will adress it in a separate change. > Otherwise seems okay to me. Thank you! /Jesper > > Thanks, > David > >> /Jesper >>> On 1 Sep 2020, at 06:49, David Holmes wrote: >>> >>> Hi Jesper, >>> >>> How do we actually view this in a readable format? >>> >>> Thanks, >>> David >>> >>> On 1/09/2020 2:26 pm, Jesper Wilhelmsson wrote: >>>> Moving the JBS label Dictionary from the OpenJDK wiki into the Guide. Did some updates of the text. >>>> I'm guessing this dictionary is missing several labels used by libraries and client since it has a hotspot background. >>>> Please let me know what labels to add (or just add them). >>>> I also moved the noreg-* description from "Change Planning" into this dictionary as I think it fits better here. All >>>> labels have anchors so you can link directly to any label in the dictionary. >>>> ------------- >>>> Commit messages: >>>> - Added JBS Label Dictionary >>>> Changes: https://git.openjdk.java.net/guide/pull/26/files >>>> Webrev: https://webrevs.openjdk.java.net/?repo=guide&pr=26&range=00 >>>> Stats: 616 lines in 3 files changed: 493 ins; 95 del; 28 mod >>>> Patch: https://git.openjdk.java.net/guide/pull/26.diff >>>> Fetch: git fetch https://git.openjdk.java.net/guide pull/26/head:pull/26 >>>> PR: https://git.openjdk.java.net/guide/pull/26 From jwilhelm at openjdk.java.net Tue Sep 1 11:43:30 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Tue, 1 Sep 2020 11:43:30 GMT Subject: RFR: Added JBS Label Dictionary [v2] In-Reply-To: <7vzFOdtXevWQtVYp6uYoywANxYL1jTpjzlXDFpJeGzU=.47686966-7478-4300-a3fc-98a2cd83567f@github.com> References: <7vzFOdtXevWQtVYp6uYoywANxYL1jTpjzlXDFpJeGzU=.47686966-7478-4300-a3fc-98a2cd83567f@github.com> Message-ID: > Moving the JBS label Dictionary from the OpenJDK wiki into the Guide. Did some updates of the text. > > I was unable to get the layout I wanted (or any readable layout really) using plain markdown, so this page uses an html > table. If anyone can achieve the same or very similar layout using plain markdown I'd be happy to remove the html. > I'm guessing this dictionary is missing several labels used by libraries and client since it has a hotspot background. > Please let me know what labels to add (or just add them). > I also moved the noreg-* description from "Change Planning" into this dictionary as I think it fits better here. All > labels have anchors so you can link directly to any label in the dictionary. Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: Fixed typo ------------- Changes: - all: https://git.openjdk.java.net/guide/pull/26/files - new: https://git.openjdk.java.net/guide/pull/26/files/62fc7c0e..fe6907e0 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=guide&pr=26&range=01 - incr: https://webrevs.openjdk.java.net/?repo=guide&pr=26&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/guide/pull/26.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/26/head:pull/26 PR: https://git.openjdk.java.net/guide/pull/26 From david.holmes at oracle.com Tue Sep 1 13:08:27 2020 From: david.holmes at oracle.com (David Holmes) Date: Tue, 1 Sep 2020 23:08:27 +1000 Subject: RFR: Added JBS Label Dictionary In-Reply-To: References: <7vzFOdtXevWQtVYp6uYoywANxYL1jTpjzlXDFpJeGzU=.47686966-7478-4300-a3fc-98a2cd83567f@github.com> <8CDC0054-58E0-4D3C-87DF-F0A0219D3495@oracle.com> <6ed30a8c-cb71-8046-ae39-f02e1b1014c0@oracle.com> Message-ID: On 1/09/2020 9:40 pm, Jesper Wilhelmsson wrote: >> On 1 Sep 2020, at 09:30, David Holmes wrote: >> >> On 1/09/2020 3:41 pm, Jesper Wilhelmsson wrote: >>> Hi David. >>> I think the easiest way is to pull the branch from the PR and build it locally. There are additional fonts and stylesheets that will be in use once the page hits the webserver, but the local result is good enough to get a sense of the page I think. >> >> Took longer than anticipated due to pandoc issues :) > > Is there anything we can to update in the instructions in the readme to avoid that others run into the same issues? Version requirements for pandoc would be good. I installed pandoc via yum install on my OEL7.4 system and it didn't support the flags the makefile was using. So then I had to tweak things so that make found the pandoc that was installed by jib and which did work. Cheers, David >> Typo: pahes > > Fixed. > >> Does "integration-blocker" have any meaning now? > > It can still be used in project repos and the client repo. Don't think anyone actually use it right now though. But I think we will see more shared workspaces as we move to git since it's so much easier to just share a fork or a branch so it may come back :-) > >> The font/formatting for foo-bar-(Rel) doesn't look good as the "(Rel)" part seems much bigger than the monospaced font used for the foo-bar- part. But that may just be a stylesheet issue with the local view. > > Yes I see that too. Looking at the final web version of the Guide tt-text has the same size as normal text, so I hope that will look better once published. If not I will adress it in a separate change. > >> Otherwise seems okay to me. > > Thank you! > /Jesper > >> >> Thanks, >> David >> >>> /Jesper >>>> On 1 Sep 2020, at 06:49, David Holmes wrote: >>>> >>>> Hi Jesper, >>>> >>>> How do we actually view this in a readable format? >>>> >>>> Thanks, >>>> David >>>> >>>> On 1/09/2020 2:26 pm, Jesper Wilhelmsson wrote: >>>>> Moving the JBS label Dictionary from the OpenJDK wiki into the Guide. Did some updates of the text. >>>>> I'm guessing this dictionary is missing several labels used by libraries and client since it has a hotspot background. >>>>> Please let me know what labels to add (or just add them). >>>>> I also moved the noreg-* description from "Change Planning" into this dictionary as I think it fits better here. All >>>>> labels have anchors so you can link directly to any label in the dictionary. >>>>> ------------- >>>>> Commit messages: >>>>> - Added JBS Label Dictionary >>>>> Changes: https://git.openjdk.java.net/guide/pull/26/files >>>>> Webrev: https://webrevs.openjdk.java.net/?repo=guide&pr=26&range=00 >>>>> Stats: 616 lines in 3 files changed: 493 ins; 95 del; 28 mod >>>>> Patch: https://git.openjdk.java.net/guide/pull/26.diff >>>>> Fetch: git fetch https://git.openjdk.java.net/guide pull/26/head:pull/26 >>>>> PR: https://git.openjdk.java.net/guide/pull/26 > From jesper.wilhelmsson at oracle.com Tue Sep 1 13:32:58 2020 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Tue, 1 Sep 2020 15:32:58 +0200 Subject: RFR: Added JBS Label Dictionary In-Reply-To: References: <7vzFOdtXevWQtVYp6uYoywANxYL1jTpjzlXDFpJeGzU=.47686966-7478-4300-a3fc-98a2cd83567f@github.com> <8CDC0054-58E0-4D3C-87DF-F0A0219D3495@oracle.com> <6ed30a8c-cb71-8046-ae39-f02e1b1014c0@oracle.com> Message-ID: <4297D962-80A6-4B52-8E2F-4AA86728D538@oracle.com> > On 1 Sep 2020, at 15:08, David Holmes wrote: > > On 1/09/2020 9:40 pm, Jesper Wilhelmsson wrote: >>> On 1 Sep 2020, at 09:30, David Holmes wrote: >>> >>> On 1/09/2020 3:41 pm, Jesper Wilhelmsson wrote: >>>> Hi David. >>>> I think the easiest way is to pull the branch from the PR and build it locally. There are additional fonts and stylesheets that will be in use once the page hits the webserver, but the local result is good enough to get a sense of the page I think. >>> >>> Took longer than anticipated due to pandoc issues :) >> Is there anything we can to update in the instructions in the readme to avoid that others run into the same issues? > > Version requirements for pandoc would be good. I installed pandoc via yum install on my OEL7.4 system and it didn't support the flags the makefile was using. So then I had to tweak things so that make found the pandoc that was installed by jib and which did work. Do you happen to have the version numbers for the two versions you tried? I started to look through the pandoc source history but it was fairly time consuming to find where all flags were introduced :-) Thanks, /Jesper > > Cheers, > David > >>> Typo: pahes >> Fixed. >>> Does "integration-blocker" have any meaning now? >> It can still be used in project repos and the client repo. Don't think anyone actually use it right now though. But I think we will see more shared workspaces as we move to git since it's so much easier to just share a fork or a branch so it may come back :-) >>> The font/formatting for foo-bar-(Rel) doesn't look good as the "(Rel)" part seems much bigger than the monospaced font used for the foo-bar- part. But that may just be a stylesheet issue with the local view. >> Yes I see that too. Looking at the final web version of the Guide tt-text has the same size as normal text, so I hope that will look better once published. If not I will adress it in a separate change. >>> Otherwise seems okay to me. >> Thank you! >> /Jesper >>> >>> Thanks, >>> David >>> >>>> /Jesper >>>>> On 1 Sep 2020, at 06:49, David Holmes wrote: >>>>> >>>>> Hi Jesper, >>>>> >>>>> How do we actually view this in a readable format? >>>>> >>>>> Thanks, >>>>> David >>>>> >>>>> On 1/09/2020 2:26 pm, Jesper Wilhelmsson wrote: >>>>>> Moving the JBS label Dictionary from the OpenJDK wiki into the Guide. Did some updates of the text. >>>>>> I'm guessing this dictionary is missing several labels used by libraries and client since it has a hotspot background. >>>>>> Please let me know what labels to add (or just add them). >>>>>> I also moved the noreg-* description from "Change Planning" into this dictionary as I think it fits better here. All >>>>>> labels have anchors so you can link directly to any label in the dictionary. >>>>>> ------------- >>>>>> Commit messages: >>>>>> - Added JBS Label Dictionary >>>>>> Changes: https://git.openjdk.java.net/guide/pull/26/files >>>>>> Webrev: https://webrevs.openjdk.java.net/?repo=guide&pr=26&range=00 >>>>>> Stats: 616 lines in 3 files changed: 493 ins; 95 del; 28 mod >>>>>> Patch: https://git.openjdk.java.net/guide/pull/26.diff >>>>>> Fetch: git fetch https://git.openjdk.java.net/guide pull/26/head:pull/26 >>>>>> PR: https://git.openjdk.java.net/guide/pull/26 From david.holmes at oracle.com Tue Sep 1 22:35:29 2020 From: david.holmes at oracle.com (David Holmes) Date: Wed, 2 Sep 2020 08:35:29 +1000 Subject: RFR: Added JBS Label Dictionary In-Reply-To: <4297D962-80A6-4B52-8E2F-4AA86728D538@oracle.com> References: <7vzFOdtXevWQtVYp6uYoywANxYL1jTpjzlXDFpJeGzU=.47686966-7478-4300-a3fc-98a2cd83567f@github.com> <8CDC0054-58E0-4D3C-87DF-F0A0219D3495@oracle.com> <6ed30a8c-cb71-8046-ae39-f02e1b1014c0@oracle.com> <4297D962-80A6-4B52-8E2F-4AA86728D538@oracle.com> Message-ID: <09e94990-f49b-b452-02ba-1be784b37168@oracle.com> On 1/09/2020 11:32 pm, Jesper Wilhelmsson wrote: >> On 1 Sep 2020, at 15:08, David Holmes wrote: >> >> On 1/09/2020 9:40 pm, Jesper Wilhelmsson wrote: >>>> On 1 Sep 2020, at 09:30, David Holmes wrote: >>>> >>>> On 1/09/2020 3:41 pm, Jesper Wilhelmsson wrote: >>>>> Hi David. >>>>> I think the easiest way is to pull the branch from the PR and build it locally. There are additional fonts and stylesheets that will be in use once the page hits the webserver, but the local result is good enough to get a sense of the page I think. >>>> >>>> Took longer than anticipated due to pandoc issues :) >>> Is there anything we can to update in the instructions in the readme to avoid that others run into the same issues? >> >> Version requirements for pandoc would be good. I installed pandoc via yum install on my OEL7.4 system and it didn't support the flags the makefile was using. So then I had to tweak things so that make found the pandoc that was installed by jib and which did work. > > Do you happen to have the version numbers for the two versions you tried? I started to look through the pandoc source history but it was fairly time consuming to find where all flags were introduced :-) Working version: 2.3.1 Bad version: 1.12.3.1 Cheers, David > Thanks, > /Jesper > >> >> Cheers, >> David >> >>>> Typo: pahes >>> Fixed. >>>> Does "integration-blocker" have any meaning now? >>> It can still be used in project repos and the client repo. Don't think anyone actually use it right now though. But I think we will see more shared workspaces as we move to git since it's so much easier to just share a fork or a branch so it may come back :-) >>>> The font/formatting for foo-bar-(Rel) doesn't look good as the "(Rel)" part seems much bigger than the monospaced font used for the foo-bar- part. But that may just be a stylesheet issue with the local view. >>> Yes I see that too. Looking at the final web version of the Guide tt-text has the same size as normal text, so I hope that will look better once published. If not I will adress it in a separate change. >>>> Otherwise seems okay to me. >>> Thank you! >>> /Jesper >>>> >>>> Thanks, >>>> David >>>> >>>>> /Jesper >>>>>> On 1 Sep 2020, at 06:49, David Holmes wrote: >>>>>> >>>>>> Hi Jesper, >>>>>> >>>>>> How do we actually view this in a readable format? >>>>>> >>>>>> Thanks, >>>>>> David >>>>>> >>>>>> On 1/09/2020 2:26 pm, Jesper Wilhelmsson wrote: >>>>>>> Moving the JBS label Dictionary from the OpenJDK wiki into the Guide. Did some updates of the text. >>>>>>> I'm guessing this dictionary is missing several labels used by libraries and client since it has a hotspot background. >>>>>>> Please let me know what labels to add (or just add them). >>>>>>> I also moved the noreg-* description from "Change Planning" into this dictionary as I think it fits better here. All >>>>>>> labels have anchors so you can link directly to any label in the dictionary. >>>>>>> ------------- >>>>>>> Commit messages: >>>>>>> - Added JBS Label Dictionary >>>>>>> Changes: https://git.openjdk.java.net/guide/pull/26/files >>>>>>> Webrev: https://webrevs.openjdk.java.net/?repo=guide&pr=26&range=00 >>>>>>> Stats: 616 lines in 3 files changed: 493 ins; 95 del; 28 mod >>>>>>> Patch: https://git.openjdk.java.net/guide/pull/26.diff >>>>>>> Fetch: git fetch https://git.openjdk.java.net/guide pull/26/head:pull/26 >>>>>>> PR: https://git.openjdk.java.net/guide/pull/26 > From david.holmes at oracle.com Tue Sep 1 22:37:25 2020 From: david.holmes at oracle.com (David Holmes) Date: Wed, 2 Sep 2020 08:37:25 +1000 Subject: RFR: Added JBS Label Dictionary [v2] In-Reply-To: References: <7vzFOdtXevWQtVYp6uYoywANxYL1jTpjzlXDFpJeGzU=.47686966-7478-4300-a3fc-98a2cd83567f@github.com> Message-ID: On 1/09/2020 9:43 pm, Jesper Wilhelmsson wrote: >> Moving the JBS label Dictionary from the OpenJDK wiki into the Guide. Did some updates of the text. >> >> I was unable to get the layout I wanted (or any readable layout really) using plain markdown, so this page uses an html >> table. If anyone can achieve the same or very similar layout using plain markdown I'd be happy to remove the html. >> I'm guessing this dictionary is missing several labels used by libraries and client since it has a hotspot background. >> Please let me know what labels to add (or just add them). >> I also moved the noreg-* description from "Change Planning" into this dictionary as I think it fits better here. All >> labels have anchors so you can link directly to any label in the dictionary. > > Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: > > Fixed typo You changed it to "phases" but it should just be "phase". David > ------------- > > Changes: > - all: https://git.openjdk.java.net/guide/pull/26/files > - new: https://git.openjdk.java.net/guide/pull/26/files/62fc7c0e..fe6907e0 > > Webrevs: > - full: https://webrevs.openjdk.java.net/?repo=guide&pr=26&range=01 > - incr: https://webrevs.openjdk.java.net/?repo=guide&pr=26&range=00-01 > > Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/guide/pull/26.diff > Fetch: git fetch https://git.openjdk.java.net/guide pull/26/head:pull/26 > > PR: https://git.openjdk.java.net/guide/pull/26 > From jwilhelm at openjdk.java.net Tue Sep 1 23:28:21 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Tue, 1 Sep 2020 23:28:21 GMT Subject: RFR: Added JBS Label Dictionary [v3] In-Reply-To: <7vzFOdtXevWQtVYp6uYoywANxYL1jTpjzlXDFpJeGzU=.47686966-7478-4300-a3fc-98a2cd83567f@github.com> References: <7vzFOdtXevWQtVYp6uYoywANxYL1jTpjzlXDFpJeGzU=.47686966-7478-4300-a3fc-98a2cd83567f@github.com> Message-ID: > Moving the JBS label Dictionary from the OpenJDK wiki into the Guide. Did some updates of the text. > > I was unable to get the layout I wanted (or any readable layout really) using plain markdown, so this page uses an html > table. If anyone can achieve the same or very similar layout using plain markdown I'd be happy to remove the html. > I'm guessing this dictionary is missing several labels used by libraries and client since it has a hotspot background. > Please let me know what labels to add (or just add them). > I also moved the noreg-* description from "Change Planning" into this dictionary as I think it fits better here. All > labels have anchors so you can link directly to any label in the dictionary. Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: Fixed typo again ------------- Changes: - all: https://git.openjdk.java.net/guide/pull/26/files - new: https://git.openjdk.java.net/guide/pull/26/files/fe6907e0..ccd95249 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=guide&pr=26&range=02 - incr: https://webrevs.openjdk.java.net/?repo=guide&pr=26&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/guide/pull/26.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/26/head:pull/26 PR: https://git.openjdk.java.net/guide/pull/26 From jesper.wilhelmsson at oracle.com Tue Sep 1 23:28:42 2020 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Wed, 2 Sep 2020 01:28:42 +0200 Subject: RFR: Added JBS Label Dictionary [v2] In-Reply-To: References: <7vzFOdtXevWQtVYp6uYoywANxYL1jTpjzlXDFpJeGzU=.47686966-7478-4300-a3fc-98a2cd83567f@github.com> Message-ID: <6894674B-4B35-4FDF-A9F1-E3C70E21C174@oracle.com> > On 2 Sep 2020, at 00:37, David Holmes wrote: > > On 1/09/2020 9:43 pm, Jesper Wilhelmsson wrote: >>> Moving the JBS label Dictionary from the OpenJDK wiki into the Guide. Did some updates of the text. >>> >>> I was unable to get the layout I wanted (or any readable layout really) using plain markdown, so this page uses an html >>> table. If anyone can achieve the same or very similar layout using plain markdown I'd be happy to remove the html. >>> I'm guessing this dictionary is missing several labels used by libraries and client since it has a hotspot background. >>> Please let me know what labels to add (or just add them). >>> I also moved the noreg-* description from "Change Planning" into this dictionary as I think it fits better here. All >>> labels have anchors so you can link directly to any label in the dictionary. >> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: >> Fixed typo > > You changed it to "phases" but it should just be "phase". D'oh! Fixed again. /Jesper > > David > >> ------------- >> Changes: >> - all: https://git.openjdk.java.net/guide/pull/26/files >> - new: https://git.openjdk.java.net/guide/pull/26/files/62fc7c0e..fe6907e0 >> Webrevs: >> - full: https://webrevs.openjdk.java.net/?repo=guide&pr=26&range=01 >> - incr: https://webrevs.openjdk.java.net/?repo=guide&pr=26&range=00-01 >> Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod >> Patch: https://git.openjdk.java.net/guide/pull/26.diff >> Fetch: git fetch https://git.openjdk.java.net/guide pull/26/head:pull/26 >> PR: https://git.openjdk.java.net/guide/pull/26 From ehelin at openjdk.java.net Wed Sep 2 09:12:02 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 2 Sep 2020 09:12:02 GMT Subject: RFR: Added JBS Label Dictionary In-Reply-To: <7vzFOdtXevWQtVYp6uYoywANxYL1jTpjzlXDFpJeGzU=.47686966-7478-4300-a3fc-98a2cd83567f@github.com> References: <7vzFOdtXevWQtVYp6uYoywANxYL1jTpjzlXDFpJeGzU=.47686966-7478-4300-a3fc-98a2cd83567f@github.com> Message-ID: On Tue, 1 Sep 2020 04:22:30 GMT, Jesper Wilhelmsson wrote: > Moving the JBS label Dictionary from the OpenJDK wiki into the Guide. Did some updates of the text. > > I was unable to get the layout I wanted (or any readable layout really) using plain markdown, so this page uses an html > table. If anyone can achieve the same or very similar layout using plain markdown I'd be happy to remove the html. > I'm guessing this dictionary is missing several labels used by libraries and client since it has a hotspot background. > Please let me know what labels to add (or just add them). > I also moved the noreg-* description from "Change Planning" into this dictionary as I think it fits better here. All > labels have anchors so you can link directly to any label in the dictionary. Please ignore this comment, it is only for debugging Skara's e-mail bridging. ------------- PR: https://git.openjdk.java.net/guide/pull/26 From erik.helin at oracle.com Thu Sep 3 07:34:08 2020 From: erik.helin at oracle.com (Erik Helin) Date: Thu, 3 Sep 2020 09:34:08 +0200 Subject: RFR: Added JBS Label Dictionary In-Reply-To: References: <7vzFOdtXevWQtVYp6uYoywANxYL1jTpjzlXDFpJeGzU=.47686966-7478-4300-a3fc-98a2cd83567f@github.com> Message-ID: On 9/2/20 11:12 AM, Erik Helin wrote: > On Tue, 1 Sep 2020 04:22:30 GMT, Jesper Wilhelmsson wrote: > >> Moving the JBS label Dictionary from the OpenJDK wiki into the Guide. Did some updates of the text. >> >> I was unable to get the layout I wanted (or any readable layout really) using plain markdown, so this page uses an html >> table. If anyone can achieve the same or very similar layout using plain markdown I'd be happy to remove the html. >> I'm guessing this dictionary is missing several labels used by libraries and client since it has a hotspot background. >> Please let me know what labels to add (or just add them). >> I also moved the noreg-* description from "Change Planning" into this dictionary as I think it fits better here. All >> labels have anchors so you can link directly to any label in the dictionary. > > Please ignore this comment, it is only for debugging Skara's e-mail bridging. Please ignore this e-mail, this is for debugging the other direction (mailing list -> GitHub). Thanks, Erik > ------------- > > PR: https://git.openjdk.java.net/guide/pull/26 > From jwilhelm at openjdk.java.net Wed Sep 16 02:33:06 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Wed, 16 Sep 2020 02:33:06 GMT Subject: RFR: Added pandoc version recommendation Message-ID: It was noted that pandoc 1.12.3.1 did not support all the flags we use in the build. V2.0 has all flags we use so I added a recommendation to use at least that version. ------------- Commit messages: - Added pandoc version recommendation Changes: https://git.openjdk.java.net/guide/pull/27/files Webrev: https://webrevs.openjdk.java.net/?repo=guide&pr=27&range=00 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/guide/pull/27.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/27/head:pull/27 PR: https://git.openjdk.java.net/guide/pull/27 From iris at openjdk.java.net Wed Sep 16 06:15:20 2020 From: iris at openjdk.java.net (Iris Clark) Date: Wed, 16 Sep 2020 06:15:20 GMT Subject: RFR: Added pandoc version recommendation In-Reply-To: References: Message-ID: <3x4S8-tNTHXXKk4KcnNeinJlZl6AII29fL_IRSPJM-s=.419a4cbf-b8e6-4fc3-8cd4-0c6a08c15f7b@github.com> On Wed, 16 Sep 2020 02:27:49 GMT, Jesper Wilhelmsson wrote: > It was noted that pandoc 1.12.3.1 did not support all the flags we use in the build. V2.0 has all flags we use so I > added a recommendation to use at least that version. Marked as reviewed by iris (Reviewer). ------------- PR: https://git.openjdk.java.net/guide/pull/27 From iris at openjdk.java.net Wed Sep 16 06:22:50 2020 From: iris at openjdk.java.net (Iris Clark) Date: Wed, 16 Sep 2020 06:22:50 GMT Subject: RFR: Adding mapping from source to mail list [v2] In-Reply-To: References: Message-ID: On Tue, 1 Sep 2020 05:35:11 GMT, Jesper Wilhelmsson wrote: >> A few directories are still not "owned" by anyone. I'd appreciate any help here. > > Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: > > Updated with Iris' additions Marked as reviewed by iris (Reviewer). ------------- PR: https://git.openjdk.java.net/guide/pull/25 From jwilhelm at openjdk.java.net Wed Sep 16 16:42:20 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Wed, 16 Sep 2020 16:42:20 GMT Subject: Integrated: Added pandoc version recommendation In-Reply-To: References: Message-ID: On Wed, 16 Sep 2020 02:27:49 GMT, Jesper Wilhelmsson wrote: > It was noted that pandoc 1.12.3.1 did not support all the flags we use in the build. V2.0 has all flags we use so I > added a recommendation to use at least that version. This pull request has now been integrated. Changeset: 62ad61b7 Author: Jesper Wilhelmsson URL: https://git.openjdk.java.net/guide/commit/62ad61b7 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Added pandoc version recommendation Reviewed-by: iris ------------- PR: https://git.openjdk.java.net/guide/pull/27 From jwilhelm at openjdk.java.net Wed Sep 16 16:44:52 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Wed, 16 Sep 2020 16:44:52 GMT Subject: Integrated: Adding mapping from source to mail list In-Reply-To: References: Message-ID: On Fri, 28 Aug 2020 17:58:08 GMT, Jesper Wilhelmsson wrote: > A few directories are still not "owned" by anyone. I'd appreciate any help here. This pull request has now been integrated. Changeset: 061a3f81 Author: Jesper Wilhelmsson URL: https://git.openjdk.java.net/guide/commit/061a3f81 Stats: 203 lines in 2 files changed: 0 ins; 203 del; 0 mod Adding mapping from source to mail list Reviewed-by: iris ------------- PR: https://git.openjdk.java.net/guide/pull/25 From prr at openjdk.java.net Fri Sep 25 19:24:01 2020 From: prr at openjdk.java.net (Phil Race) Date: Fri, 25 Sep 2020 19:24:01 GMT Subject: RFR: Filing bug, ProblemListing, Backing out [v8] In-Reply-To: <8HKsZLV1digCujn0pn99h3ZWtH2-e1I40u9W3OE2o70=.12aa1850-2fef-43d8-b6e1-eca61925d344@github.com> References: <6K28E8WDp4kNYhAs-o8jkcRFSzqdfSUqoeN92iXGgxM=.98bae31f-987a-40ca-988e-b2af5e1ff788@github.com> <8HKsZLV1digCujn0pn99h3ZWtH2-e1I40u9W3OE2o70=.12aa1850-2fef-43d8-b6e1-eca61925d344@github.com> Message-ID: <0eJHyR0xV23T4xZW-AJRTJj_VDwc5_svqG5WhClcdv8=.345d5cdc-f104-4970-9497-7cc1d6b59072@github.com> On Thu, 27 Aug 2020 18:29:29 GMT, Jesper Wilhelmsson wrote: >> Filing bug, ProblemListing, Backing out > > Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: > > Added note about narrowing down bugs src/next.md line 47: > 45: > 46: I'll say it right away so that it's not forgotten at the end: Remember to remove the JBS id from the ProblemList or > the test when the bug is closed. This is especially easy to forget if a bug is closed as a duplicate or 'Will Not Fix'. > 47: I think @iignatev pushed a jcheck update that will fail if the bug in the commit matches one in the problem list and it isn't being removed in the commit. So maybe we can add a note about that. ------------- PR: https://git.openjdk.java.net/guide/pull/21 From jwilhelm at openjdk.java.net Sun Sep 27 23:30:10 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Sun, 27 Sep 2020 23:30:10 GMT Subject: RFR: Filing bug, ProblemListing, Backing out [v9] In-Reply-To: <6K28E8WDp4kNYhAs-o8jkcRFSzqdfSUqoeN92iXGgxM=.98bae31f-987a-40ca-988e-b2af5e1ff788@github.com> References: <6K28E8WDp4kNYhAs-o8jkcRFSzqdfSUqoeN92iXGgxM=.98bae31f-987a-40ca-988e-b2af5e1ff788@github.com> Message-ID: > Filing bug, ProblemListing, Backing out Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: Comment about vulnerabilities, and jcheck on ProblemLists ------------- Changes: - all: https://git.openjdk.java.net/guide/pull/21/files - new: https://git.openjdk.java.net/guide/pull/21/files/74bd7fd3..c66a78ab Webrevs: - full: https://webrevs.openjdk.java.net/?repo=guide&pr=21&range=08 - incr: https://webrevs.openjdk.java.net/?repo=guide&pr=21&range=07-08 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/guide/pull/21.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/21/head:pull/21 PR: https://git.openjdk.java.net/guide/pull/21 From jwilhelm at openjdk.java.net Sun Sep 27 23:30:10 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Sun, 27 Sep 2020 23:30:10 GMT Subject: RFR: Filing bug, ProblemListing, Backing out [v8] In-Reply-To: <0eJHyR0xV23T4xZW-AJRTJj_VDwc5_svqG5WhClcdv8=.345d5cdc-f104-4970-9497-7cc1d6b59072@github.com> References: <6K28E8WDp4kNYhAs-o8jkcRFSzqdfSUqoeN92iXGgxM=.98bae31f-987a-40ca-988e-b2af5e1ff788@github.com> <8HKsZLV1digCujn0pn99h3ZWtH2-e1I40u9W3OE2o70=.12aa1850-2fef-43d8-b6e1-eca61925d344@github.com> <0eJHyR0xV23T4xZW-AJRTJj_VDwc5_svqG5WhClcdv8=.345d5cdc-f104-4970-9497-7cc1d6b59072@github.com> Message-ID: <0kP06sDqAfxYRthhQX6e67umqxDxX_Sdo5s-gBgpGDQ=.aad12953-25a2-42df-b94a-69307daed805@github.com> On Fri, 25 Sep 2020 19:21:50 GMT, Phil Race wrote: >> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: >> >> Added note about narrowing down bugs > > src/next.md line 47: > >> 45: >> 46: I'll say it right away so that it's not forgotten at the end: Remember to remove the JBS id from the ProblemList or >> the test when the bug is closed. This is especially easy to forget if a bug is closed as a duplicate or 'Will Not Fix'. >> 47: > > I think @iignatev pushed a jcheck update that will fail if the bug in the commit matches one in the problem list and it > isn't being removed in the commit. So maybe we can add a note about that. Yes, good point! I have added a sentence about that. ------------- PR: https://git.openjdk.java.net/guide/pull/21 From jwilhelm at openjdk.java.net Sun Sep 27 23:33:23 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Sun, 27 Sep 2020 23:33:23 GMT Subject: RFR: Filing bug, ProblemListing, Backing out [v7] In-Reply-To: References: <6K28E8WDp4kNYhAs-o8jkcRFSzqdfSUqoeN92iXGgxM=.98bae31f-987a-40ca-988e-b2af5e1ff788@github.com> Message-ID: <_X-D-exfXQ4LHhzEH5ApdPDNYU3gklJ7kRG6RkeWMHY=.a6246602-7ab8-4d8f-885e-efa1ccb81442@github.com> On Wed, 26 Aug 2020 18:19:46 GMT, Kevin Rushforth wrote: >> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: >> >> Updated with Alan's suggestions > > src/next.md line 28: > >> 26: * Add relevant labels like `intermittent`, `regression`, `noreg-self` etc. >> 27: * Set affects version to the JDK version(s) where the failure was seen. >> 28: * If the failure is found in an update train of the JDK (e.g. 11.0.x), please make an effort to see if the bug is >> also present in [mainline](https://hg.openjdk.java.net/jdk/jdk/). > > This isn't really a comment on your proposed change. I presume there will be a follow-on task to update the docs after > next week when the jdk repo transitions from Mercurial to Git? Yes, there is a Skara bug filed to update the guide, https://bugs.openjdk.java.net/browse/SKARA-652 ------------- PR: https://git.openjdk.java.net/guide/pull/21 From iris at openjdk.java.net Tue Sep 29 21:55:51 2020 From: iris at openjdk.java.net (Iris Clark) Date: Tue, 29 Sep 2020 21:55:51 GMT Subject: RFR: Filing bug, ProblemListing, Backing out [v9] In-Reply-To: References: <6K28E8WDp4kNYhAs-o8jkcRFSzqdfSUqoeN92iXGgxM=.98bae31f-987a-40ca-988e-b2af5e1ff788@github.com> Message-ID: On Sun, 27 Sep 2020 23:30:10 GMT, Jesper Wilhelmsson wrote: >> Filing bug, ProblemListing, Backing out > > Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: > > Comment about vulnerabilities, and jcheck on ProblemLists Thanks for adding this information to the Guide and patiently working will reviewers to address their concerns. ------------- Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/guide/pull/21