From iris at openjdk.java.net Thu Apr 1 01:27:16 2021 From: iris at openjdk.java.net (Iris Clark) Date: Thu, 1 Apr 2021 01:27:16 GMT Subject: RFR: Updated directory mapping for JDK 16 In-Reply-To: <0WU5wjx8XqsfS9Cs7DBEN7Lr194kDUXgetgkgEByM5M=.c98ed5f0-99aa-412e-9300-336a5dfa1b96@github.com> References: <0WU5wjx8XqsfS9Cs7DBEN7Lr194kDUXgetgkgEByM5M=.c98ed5f0-99aa-412e-9300-336a5dfa1b96@github.com> Message-ID: On Wed, 31 Mar 2021 23:50:43 GMT, Jesper Wilhelmsson wrote: > A couple of new directories has been added in JDK 16. Marked as reviewed by iris (Reviewer). ------------- PR: https://git.openjdk.java.net/guide/pull/54 From jwilhelm at openjdk.java.net Thu Apr 1 05:23:11 2021 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Thu, 1 Apr 2021 05:23:11 GMT Subject: Integrated: Updated directory mapping for JDK 16 In-Reply-To: <0WU5wjx8XqsfS9Cs7DBEN7Lr194kDUXgetgkgEByM5M=.c98ed5f0-99aa-412e-9300-336a5dfa1b96@github.com> References: <0WU5wjx8XqsfS9Cs7DBEN7Lr194kDUXgetgkgEByM5M=.c98ed5f0-99aa-412e-9300-336a5dfa1b96@github.com> Message-ID: On Wed, 31 Mar 2021 23:50:43 GMT, Jesper Wilhelmsson wrote: > A couple of new directories has been added in JDK 16. This pull request has now been integrated. Changeset: 3216e9cf Author: Jesper Wilhelmsson URL: https://git.openjdk.java.net/guide/commit/3216e9cf Stats: 5 lines in 1 file changed: 2 ins; 0 del; 3 mod Updated directory mapping for JDK 16 Reviewed-by: iris ------------- PR: https://git.openjdk.java.net/guide/pull/54 From iris at openjdk.java.net Fri Apr 2 18:54:23 2021 From: iris at openjdk.java.net (Iris Clark) Date: Fri, 2 Apr 2021 18:54:23 GMT Subject: RFR: Cleaned up tidy warnings In-Reply-To: <3t_ZIASj2n5WBvayf9ldd8lzdJEv-K5ZweqNySFwS_I=.3dec627f-9ffa-4916-8ada-24f37181fdcd@github.com> References: <3t_ZIASj2n5WBvayf9ldd8lzdJEv-K5ZweqNySFwS_I=.3dec627f-9ffa-4916-8ada-24f37181fdcd@github.com> Message-ID: On Thu, 25 Mar 2021 01:30:45 GMT, Jesper Wilhelmsson wrote: > Cleaned up two more html tidy warnings. Marked as reviewed by iris (Reviewer). ------------- PR: https://git.openjdk.java.net/guide/pull/53 From jwilhelm at openjdk.java.net Fri Apr 2 19:43:20 2021 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Fri, 2 Apr 2021 19:43:20 GMT Subject: Integrated: Cleaned up tidy warnings In-Reply-To: <3t_ZIASj2n5WBvayf9ldd8lzdJEv-K5ZweqNySFwS_I=.3dec627f-9ffa-4916-8ada-24f37181fdcd@github.com> References: <3t_ZIASj2n5WBvayf9ldd8lzdJEv-K5ZweqNySFwS_I=.3dec627f-9ffa-4916-8ada-24f37181fdcd@github.com> Message-ID: On Thu, 25 Mar 2021 01:30:45 GMT, Jesper Wilhelmsson wrote: > Cleaned up two more html tidy warnings. This pull request has now been integrated. Changeset: 30b1c296 Author: Jesper Wilhelmsson URL: https://git.openjdk.java.net/guide/commit/30b1c296 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Cleaned up tidy warnings Reviewed-by: ihse, iris ------------- PR: https://git.openjdk.java.net/guide/pull/53 From jwilhelm at openjdk.java.net Tue Apr 6 22:58:38 2021 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Tue, 6 Apr 2021 22:58:38 GMT Subject: RFR: Update README.md Message-ID: Added todo item ------------- Commit messages: - Update README.md Changes: https://git.openjdk.java.net/guide/pull/55/files Webrev: https://webrevs.openjdk.java.net/?repo=guide&pr=55&range=00 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/guide/pull/55.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/55/head:pull/55 PR: https://git.openjdk.java.net/guide/pull/55 From iris at openjdk.java.net Tue Apr 6 23:06:14 2021 From: iris at openjdk.java.net (Iris Clark) Date: Tue, 6 Apr 2021 23:06:14 GMT Subject: RFR: Update README.md In-Reply-To: References: Message-ID: On Tue, 6 Apr 2021 22:54:14 GMT, Jesper Wilhelmsson wrote: > Added todo item Marked as reviewed by iris (Reviewer). ------------- PR: https://git.openjdk.java.net/guide/pull/55 From jwilhelm at openjdk.java.net Tue Apr 6 23:30:17 2021 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Tue, 6 Apr 2021 23:30:17 GMT Subject: Integrated: Update README.md In-Reply-To: References: Message-ID: On Tue, 6 Apr 2021 22:54:14 GMT, Jesper Wilhelmsson wrote: > Added todo item This pull request has now been integrated. Changeset: 86fabc81 Author: Jesper Wilhelmsson URL: https://git.openjdk.java.net/guide/commit/86fabc81 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Update README.md Reviewed-by: iris ------------- PR: https://git.openjdk.java.net/guide/pull/55 From jesper.wilhelmsson at oracle.com Fri Apr 9 11:42:59 2021 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Fri, 9 Apr 2021 13:42:59 +0200 Subject: Make targets Message-ID: Hi, I'm writing a section about building the JDK from source and need some inspiration :-) What make targets do you normally use and why? Thanks! /Jesper From philip.race at oracle.com Fri Apr 9 14:41:00 2021 From: philip.race at oracle.com (Philip Race) Date: Fri, 9 Apr 2021 07:41:00 -0700 Subject: Make targets In-Reply-To: References: Message-ID: <5f2dadf7-53be-4c32-7cf8-643945178535@oracle.com> In order of most often to least often make - I am doing a basic dev cycle make demos - I want to test UI and this creates the demos which make it easy to do that make images - I am doing something which just maybe has a build aspect to it, or I ????? want to test something closer to the shipping product -phil. On 4/9/21 4:42 AM, Jesper Wilhelmsson wrote: > Hi, > > I'm writing a section about building the JDK from source and need some inspiration :-) > > What make targets do you normally use and why? > > Thanks! > /Jesper > From joe.darcy at oracle.com Fri Apr 9 19:13:33 2021 From: joe.darcy at oracle.com (Joe Darcy) Date: Fri, 9 Apr 2021 12:13:33 -0700 Subject: Make targets In-Reply-To: References: Message-ID: <21ee2cd7-3cdb-a595-8de6-388c4a5f9365@oracle.com> If updating the javadoc, I recommend "make docs" to check the results. -Joe On 4/9/2021 4:42 AM, Jesper Wilhelmsson wrote: > Hi, > > I'm writing a section about building the JDK from source and need some inspiration :-) > > What make targets do you normally use and why? > > Thanks! > /Jesper > From iris.clark at oracle.com Fri Apr 9 19:59:49 2021 From: iris.clark at oracle.com (Iris Clark) Date: Fri, 9 Apr 2021 19:59:49 +0000 Subject: Make targets In-Reply-To: <21ee2cd7-3cdb-a595-8de6-388c4a5f9365@oracle.com> References: , <21ee2cd7-3cdb-a595-8de6-388c4a5f9365@oracle.com> Message-ID: Hi, Jesper. I second "make docs". That and "make clean" are my most used make targets when I'm working on the platform JSR. (Yes, that's pretty unique and rather specific...) Note that a number of classes in the javadoc API are generated during the build, so "make docs" might do more than simply invoke javadoc, depending on the state of your build. Thanks, Iris ________________________________ From: guide-dev on behalf of Joe Darcy Sent: Friday, April 9, 2021 12:13 PM To: Jesper Wilhelmsson ; guide-dev at openjdk.java.net Subject: Re: Make targets If updating the javadoc, I recommend "make docs" to check the results. -Joe On 4/9/2021 4:42 AM, Jesper Wilhelmsson wrote: > Hi, > > I'm writing a section about building the JDK from source and need some inspiration :-) > > What make targets do you normally use and why? > > Thanks! > /Jesper > From Alan.Bateman at oracle.com Sat Apr 10 07:01:01 2021 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Sat, 10 Apr 2021 08:01:01 +0100 Subject: Make targets In-Reply-To: References: Message-ID: <7c7c9c9f-a72d-3c9d-f6f4-3305b4d052eb@oracle.com> On 09/04/2021 12:42, Jesper Wilhelmsson wrote: > Hi, > > I'm writing a section about building the JDK from source and need some inspiration :-) > > What make targets do you normally use and why? I assume you'll want a section here on incremental builds. I mostly work with exploded builds so I regularly use "make java.base" to just re-build the base module. More generally it's "make $MODULE". On some occasions,? say when doing significant renaming or refactoring then you might need to use "make clean-$MODULE" to blow away the build output for a specific module. Incremental builds aren't perfect so the text around this probably should set expectations. I use "make docs-javase" when working on API docs, more generally "make docs". There are several make targets here that probably only a few people will use (people starting out will probably not need to know about these). -Alan. From david.holmes at oracle.com Sun Apr 11 12:44:40 2021 From: david.holmes at oracle.com (David Holmes) Date: Sun, 11 Apr 2021 22:44:40 +1000 Subject: Make targets In-Reply-To: References: Message-ID: <17172218-1c17-4fef-5cf9-c960d22e74ca@oracle.com> On 9/04/2021 9:42 pm, Jesper Wilhelmsson wrote: > Hi, > > I'm writing a section about building the JDK from source and need some inspiration :-) > > What make targets do you normally use and why? That will be highly developer dependent. :) Perhaps a target often overlooked until one tries to executes tests that need it is test-image. When fixing a bug I commonly use "make jdk-image test-image" so I can test the fix. When working on bigger code changes that likely need a lot of edit-compile cycles I'll get "make hotspot" working first. Cheers, David > Thanks! > /Jesper > From jwilhelm at openjdk.java.net Wed Apr 28 00:29:05 2021 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Wed, 28 Apr 2021 00:29:05 GMT Subject: RFR: Added build section Message-ID: <0t_yfwhtAT4iWhRBV5QAgGjTxYsDuNcCGgmlJ3qy6i4=.274a7996-05f3-4e69-ba1c-5c8cd7968e90@github.com> Instructions on how to build the JDK. ------------- Commit messages: - Added build section Changes: https://git.openjdk.java.net/guide/pull/56/files Webrev: https://webrevs.openjdk.java.net/?repo=guide&pr=56&range=00 Stats: 71 lines in 1 file changed: 71 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/guide/pull/56.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/56/head:pull/56 PR: https://git.openjdk.java.net/guide/pull/56 From jesper.wilhelmsson at oracle.com Wed Apr 28 00:30:47 2021 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Wed, 28 Apr 2021 02:30:47 +0200 Subject: Make targets In-Reply-To: References: Message-ID: <65076892-1707-49EC-8330-7543DE58799E@oracle.com> Thank you all for your comments! I have now published a PR for the build section. This can clearly be improved on, but I hope it's enough for a first version. I have based the content on your comments so you may recognise some sentences :-) /Jesper > On 9 Apr 2021, at 13:42, Jesper Wilhelmsson wrote: > > Hi, > > I'm writing a section about building the JDK from source and need some inspiration :-) > > What make targets do you normally use and why? > > Thanks! > /Jesper > From dholmes at openjdk.java.net Thu Apr 29 22:25:59 2021 From: dholmes at openjdk.java.net (David Holmes) Date: Thu, 29 Apr 2021 22:25:59 GMT Subject: RFR: Added build section In-Reply-To: <0t_yfwhtAT4iWhRBV5QAgGjTxYsDuNcCGgmlJ3qy6i4=.274a7996-05f3-4e69-ba1c-5c8cd7968e90@github.com> References: <0t_yfwhtAT4iWhRBV5QAgGjTxYsDuNcCGgmlJ3qy6i4=.274a7996-05f3-4e69-ba1c-5c8cd7968e90@github.com> Message-ID: <2h8JP-rxrKKNTqaMSDdHCi5Na9HWpL5nmIBgd_z2TSc=.480ecbe1-8608-448f-8bd4-38c7bc995eef@github.com> On Wed, 28 Apr 2021 00:24:44 GMT, Jesper Wilhelmsson wrote: > Instructions on how to build the JDK. Seems okay though I'm not sure how much can/should go in this guide. I don't see any link to the actual build docs though. Thanks, David src/index.md line 995: > 993: The JDK build system is a fairly complex machine that has the ability to build anything from a single module to a complete shippable JDK bundle with various levels of debug capabilities, run tests, install your newly built JDK on your system, or cross-compile for some other system. The build uses `make` and a few other tools that you will have to install on your system before starting. > 994: > 995: The JDK supports incremental builds. This means that if you have a complete build and make changes in just a single part of the JDK (e.g. a module or part of the JVM), only that particular part needs to be rebuilt. So subsequent builds will be faster and you can always use a make target that results in a complete JDK image without having to worry about actually building the entire JDK every time. Please note that the incremental build do have limmits in its understanding of what you change. For instance, if you change behaviors or conventions in one module there may be other parts of the JDK that implicitly depends on these without make's knowledge. For this reason you may have to rebuild several modules, or do a clean build if you change things that may have a wider impact. typo: limmits src/index.md line 997: > 995: The JDK supports incremental builds. This means that if you have a complete build and make changes in just a single part of the JDK (e.g. a module or part of the JVM), only that particular part needs to be rebuilt. So subsequent builds will be faster and you can always use a make target that results in a complete JDK image without having to worry about actually building the entire JDK every time. Please note that the incremental build do have limmits in its understanding of what you change. For instance, if you change behaviors or conventions in one module there may be other parts of the JDK that implicitly depends on these without make's knowledge. For this reason you may have to rebuild several modules, or do a clean build if you change things that may have a wider impact. > 996: > 997: The log below shows the steps taken to download and build the JDK source code from the mainline JDK development GIT repository. The configure script will tell you what additional packages you need. In this particular case several packages was needed since this build was performed on a clean Ubuntu installation. The configure script was run several times to get all the dependencies, but only the commands actually needed to get the JDK built is included in the log. s/was needed/were needed/ s/is included/are included/ src/index.md line 1049: > 1047: | `docs` | Builds the javadoc. Note that a number of classes in the javadoc API are generated during the build, so `make docs` might do more than simply invoke `javadoc`, depending on the state of your build. | > 1048: | `java.base` | Builds the base module. You can (re)build any module with `make `. | > 1049: | `hotspot` | Builds only the JVM. | And any dependencies, which includes quite a bit actually. ------------- Marked as reviewed by dholmes (Author). PR: https://git.openjdk.java.net/guide/pull/56