Request for reviews (S): 7080431: VM asserts if specified size(x) in .ad is larger than emitted size

Vladimir Kozlov vladimir.kozlov at oracle.com
Wed Aug 17 18:53:24 PDT 2011


Thank you, Tom

Vladimir

On 8/17/11 6:46 PM, Tom Rodriguez wrote:
>
> On Aug 17, 2011, at 6:20 PM, Vladimir Kozlov wrote:
>
>> On 8/17/11 5:55 PM, Tom Rodriguez wrote:
>>> Is this effectively a partial anti-delta of the fill_buffer changes?
>>
>> Yes for inserting padding and block alignment. It never did branch shortening and corresponding offsets verification.
>
> I compared it with the previous one and it looks good.  Thanks for fixing this.
>
> tom
>
>>
>> Vladimir
>>
>>>
>>> tom
>>>
>>> On Aug 17, 2011, at 5:35 PM, Vladimir Kozlov wrote:
>>>
>>>> http://cr.openjdk.java.net/~kvn/7080431/webrev
>>>>
>>>> 7080431: VM asserts if specified size(x) in .ad is larger than emitted size
>>>>
>>>> It was allowed to specify larger size(x) in mach node definition in .ad file than actual emitted instruction size. It was treated as upper bound on instruction size. 7063629 changes broke that, it requires size(x) in mach node definition match the emitted size which reduced flexibility in C2 development.
>>>>
>>>> Move code from finalize_offsets_and_shorten() to fill_buffer() to restore previous behavior.
>>>
>


More information about the hotspot-compiler-dev mailing list