Request for reviews (S): 7071709: JSR 292: switchpoint invalidation should be pushed not pulled

Tom Rodriguez tom.rodriguez at oracle.com
Thu Aug 25 09:55:19 PDT 2011


Why is this being done for VolatileCallSite?  There's no mechanism for falling back if the field is invalided too many times so we're just going to recompile over and over again which seems wrong.  Otherwise it looks ok.

tom

On Aug 25, 2011, at 6:54 AM, Christian Thalinger wrote:

> http://cr.openjdk.java.net/~twisti/7071709/
> 
> 7071709: JSR 292: switchpoint invalidation should be pushed not pulled
> Reviewed-by:
> 
> SwitchPoints use a MutableCallSite for its implementation.  The fix is
> to treat the target field of constant CallSites as a compile time
> constant and add a dependence for invalidation of the optimization.
> 
> src/share/vm/opto/memnode.cpp
> src/share/vm/opto/parse3.cpp
> 



More information about the hotspot-compiler-dev mailing list