Request for review (S): C2 should recognize "obj.getClass() == A.class" code pattern

Vladimir Kozlov vladimir.kozlov at oracle.com
Fri May 18 10:10:58 PDT 2012


I finally have time to look on it and it looks good. I will work on it next week (CR, testing, push).

Thanks,
Vladimir

On 5/6/12 7:08 PM, Krystal Mok wrote:
> Hi all,
>
> Updated the patch again, posted at: https://gist.github.com/2622617#file_class_eq_ver_5.patch
> Could I get some reviews for this new version, please? And, would anyone sponsor this patch, pleae?
>
> Per John's suggestion, in Parse::adjust_map_after_if(), I've factored the logic from "int val_in_map" downward into a
> new subroutine sharpen_type_after_if(), which handles comparison with constant klass as well as the old cases. I tried a
> few times but I just can't find a clean factoring.
>
> Tested SPECjvm2008 with default arguments on a jvmg build, and it ran okay.
>
> Regards,
> Kris


More information about the hotspot-compiler-dev mailing list