[9] RFR(S): 8051415: TypeTuple::make_domain() and TypeTuple::make_range() allocate too much memory

[Vladimir Kozlov]

Good.

Thanks,
Vladimir

On 8/26/14 8:14 AM, Zoltan Majo wrote:
> Hi Vladimir,
>
>
> thank you for the comments.
>
> On 08/25/2014 06:56 PM, Vladimir Kozlov wrote:
>> Please, fix copyright year in type.hpp.
>> May be rename total_fields to arg_cnt since it is not 'total' now.
>
> I did that, here is the new webrev:
>
> http://cr.openjdk.java.net/~zmajo/8051415/webrev.01/
>
> I ran JPRT and CompileTheWorld with rt.jar again, just to be sure.
>
> Thanks and best regards,
>
>
> Zoltan
>
>
>> Thanks,
>> Vladimir
>>
>> On 8/25/14 8:33 AM, Zoltán Majó wrote:
>>> Hi,
>>>
>>>
>>> please review the following patch.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8051415
>>>
>>> Problem: The methods TypeTuple::make_domain() and TypeTuple::make_range() allocate too much memory for field_array. Both
>>> methods allocate memory explicitly for TypeFunc::Parms; the fields() method they use for allocation allocates memory for
>>> TypeFunc::Parms as well.
>>>
>>> Solution: Change memory allocation in TypeTuple::make_domain() and TypeTuple::make_range() to not allocate memory for
>>> TypeFunc::Parms.
>>>
>>> Webrev: http://cr.openjdk.java.net/~zmajo/8051415/webrev.00/
>>>
>>> Testing:
>>>
>>> - JPRT
>>> - JTREG
>>> - CompileTheWorld rt.jar
>>>
>>> Thank you and best regards,
>>>
>>>
>>> Zoltan
>>>
>