[9] RFR (XS): JDK-8066862: TestMutuallyExclusivePlatformPredicates fails on all platforms

[Filipp Zhinkin]

Thank you, Vladimir.

Regards,
Filipp.

On 12/11/2014 09:42 PM, Vladimir Kozlov wrote:
> Good.
>
> Thanks,
> Vladimir
>
> On 12/11/14 4:33 AM, Filipp Zhinkin wrote:
>> Vladimir,
>>
>> thank you for review.
>>
>> Bengt's fix already pushed into gc repo,
>> so I've just updated webrev to use gc repo instead of comp one:
>>
>> http://cr.openjdk.java.net/~fzhinkin/8066862/webrev.01/
>>
>> Thanks,
>> Filipp.
>>
>> On 12/10/2014 09:54 PM, Vladimir Kozlov wrote:
>>> Filipp,
>>>
>>> Your changes  are in conflict with 8067115 changes in hs-gc repo:
>>>
>>> http://cr.openjdk.java.net/~brutisso/8067115/webrev.00/
>>>
>>> Please, use gc repo instead of hs-comp and coordinate the push with Bengt.
>>>
>>> Otherwise looks good.
>>>
>>> Thanks,
>>> Vladimir
>>>
>>> On 12/10/14 5:48 AM, Filipp Zhinkin wrote:
>>>> Hi all,
>>>>
>>>> please review a fix for 8066862.
>>>>
>>>> Issue:
>>>> testlibrary_tests/TestMutuallyExclusivePlatformPredicates.java fails with
>>>> RuntimeException: All Platform's methods with signature '():Z' should be
>>>> tested
>>>>
>>>> Root cause:
>>>> In order to prevent issues caused by the fact that some mutually exclusive
>>>> predicates may return "true" on on the same platform (for example if
>>>> isARM and
>>>> isPPC will return true simultaneously) I decided to check in test if all
>>>> Platform's methods with '():Z' signature were tested.
>>>>
>>>> Fix for 8039995 added new methods with "():Z" signature, but these
>>>> methods were
>>>> not marked in TestMutuallyExclusivePlatformPredicates as methods that
>>>> should be ignored.
>>>>
>>>> Proposed fix:
>>>> Mark newly added methods as ignored in
>>>> TestMutuallyExclusivePlatformPredicates.java,
>>>> add this test to sanity test group in order to run it in JPRT
>>>>
>>>>
>>>> Bug id: https://bugs.openjdk.java.net/browse/JDK-8066862
>>>> Webrev: http://cr.openjdk.java.net/~fzhinkin/8066862/webrev.00/
>>>> Testing: manual & automated
>>