RFR(XS): 8062012: test/compiler/ciReplay/TestSA.sh should be updated to work w/ modular image build
Tatiana Pivovarova
tatiana.pivovarova at oracle.com
Fri Dec 19 13:11:18 UTC 2014
Hi Filipp,
Thanks for the review! I will be more attentive with ID)
webrev: http://cr.openjdk.java.net/~tpivovarova/8062012/webrev.01/
Tatiana
On 12/19/2014 03:45 PM, Filipp Zhinkin wrote:
> Tatiana,
>
> The change itself looks good, but you have to use IDs instead of full
> names in "reviewed-by".
>
> Thanks,
> Filipp.
>
> On 12/19/2014 04:44 PM, Tatiana Pivovarova wrote:
>> Hi all,
>>
>> please review this small patch
>>
>> bugid: https://bugs.openjdk.java.net/browse/JDK-8062012
>> webrev: http://cr.openjdk.java.net/~tpivovarova/8062012/webrev.00/
>>
>> Problem:
>> TestSA.sh adds sa-jdi.jar to classpath, there are no such jar in
>> modular image
>>
>> Solution:
>> All classes from this jar are available in appmodules.jimage. so we
>> just need to remove mention of the jar
>> And this test will be still ignored because of another bug [*]
>>
>> Testing: jprt
>>
>> [*] https://bugs.openjdk.java.net/browse/JDK-8029528
>>
>> Thanks,
>> Tatiana
>
More information about the hotspot-compiler-dev
mailing list