[9] RFR (XXS): 8049528: Method marked w/ @ForceInline isn't inlined with "executed < MinInliningThreshold times" message
Roland Westrelin
roland.westrelin at oracle.com
Tue Jul 8 12:15:36 UTC 2014
> http://cr.openjdk.java.net/~vlivanov/8049528/webrev.00/
> https://bugs.openjdk.java.net/browse/JDK-8049528
>
> There's a missing case for @ForceInline in InlineTree::should_not_inline, so sometimes inlining fails w/ "executed < MinInliningThreshold times".
>
> The fix is to add missed check.
>
> Testing: manual (no inlining failures in the log), octane (no regresssions).
Then:
259 if (!callee_method->force_inline()) {
is useless.
If it doesn’t affect performance why do we want to make that change? Isn’t there a risk that more inlining would exhaust the inlining budget and cause a performance degradation?
Roland.
More information about the hotspot-compiler-dev
mailing list