[9] RFR(M): 8040213: C2 does not put all modified nodes on IGVN worklist

[Vladimir Kozlov]

Thank you for doing this cleanup, Tobias.

Looks good. Small note, in divnode.cpp please use explicit NULL checks:

if (in(0) != NULL) {

Thanks,
Vladimir

On 7/3/14 11:50 PM, Tobias Hartmann wrote:
> Hi,
>
> please review the following patch for 8040213 that finishes Vladimir’s
> work [1].
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8040213
> Webrev: http://cr.openjdk.java.net/~thartmann/8040213/webrev.00/
> *
> **Problem*
> Not all nodes that are modified during C2 optimization are put on the
> IGVN worklist.
>
> *Solution*
> Verification code is added that checks if (i) modified nodes are put on
> the IGVN worklist and (ii) modified nodes are processed by
> PhaseIterGVN::transform_old(..). All code that fails verification during
> testing is fixed.
> *
> **Testing:*
> - JPRT
> - Full CTW
> - Nashorn + Octane
> - UTE (full testlist, BigApps, JRuby)
> - VM (NSK) testbase
> - Refworkload (reference_server)
> - VMSQE.adhoc.JPRT.full batch
>
> Thanks,
> Tobias
>
> [1] http://cr.openjdk.java.net/~kvn/8040213/webrev/