[9] RFR(S): 8040121: Load variable through a pointer of an incompatible type in src/hotspot/src/share/vm: opto/output.cpp [...]

Tobias Hartmann tobias.hartmann at oracle.com
Thu Jul 24 12:23:02 UTC 2014


Hi,

please review the following patch that fixes the Parfait warnings listed 
in JDK-8040121.

Bug: https://bugs.openjdk.java.net/browse/JDK-8040121
Webrev: http://cr.openjdk.java.net/~thartmann/8040121/webrev.00/

The " Load variable through a pointer of an incompatible type" warnings 
in following files were fixed:

- hotspot.src.share.vm.opto.output.cpp::Compile::FillLocArray
-> Pointer cast is replaced by union

- hotspot.src.share.vm.runtime.sharedRuntimeTrans.cpp::copysign
- hotspot.src.share.vm.runtime.sharedRuntimeTrans.cpp::scalbn
-> JDK-8043301 moved these methods to sharedRuntimeMath.cpp, the 
warnings will be fixed with JDK-8049043

- hotspot.src.share.vm.utilities.globalDefinitions_visCPP.hpp::jdouble
- hotspot.src.share.vm.utilities.globalDefinitions_visCPP.hpp::jfloat
- hotspot.src.share.vm.utilities.globalDefinitions_visCPP.hpp::jint
- hotspot.src.share.vm.utilities.globalDefinitions_visCPP.hpp::jlong
-> Same methods are in globalDefinitions_gcc.hpp, 
globalDefinitions_sparcWorks.hpp, globalDefinitions_xlc.hpp. Because 
they are not compiler specific, I moved the methods into 
globalDefinitions.hpp. The casts are now implemented using a union.

Testing: Parfait, JPRT

Thanks,
Tobias
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20140724/2ac37ade/attachment.html>


More information about the hotspot-compiler-dev mailing list