[9] RFR(S): 8059847: complement JDK-8055286 and JDK-8056964 changes

Vladimir Kozlov vladimir.kozlov at oracle.com
Tue Oct 7 20:46:35 UTC 2014


On 10/7/14 11:06 AM, David Chase wrote:
> Not a R-reviewer, but I approve.

+1 as Reviewer :)

> Do we need to add a test (? what would it look like?) to ensure that it works?

Yes, please, add a regression test.

Thanks,
Vladimir

>
> David
>
> On 2014-10-07, at 1:53 PM, Zoltán Majó <zoltan.majo at oracle.com> wrote:
>
>> Hi,
>>
>>
>> please review the following small patch.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8059847
>>
>> Problem: CompileCommand=option does not support flags of type double.
>>
>> Solution: Add support for flags of type double. Output:
>>
>> java -XX:CompileCommand=option,Test::test,ccstrlist,MyListOption,_foo,_bar -XX:CompileCommand=option,Test::test,ccstr,MyStrOption,_foo -XX:CompileCommand=option,Test::test,bool,MyBoolOption,false -XX:CompileCommand=option,Test::test,intx,MyIntxOption,-1 -XX:CompileCommand=option,Test::test,uintx,MyUintxOption,1 -XX:CompileCommand=option,Test::test,MyFlag -XX:CompileCommand=option,Test::test,double,MyDoubleOption,1.123 -version
>>
>> CompilerOracle: option Test.test const char* MyListOption = '_foo _bar'
>> CompilerOracle: option Test.test const char* MyStrOption = '_foo'
>> CompilerOracle: option Test.test bool MyBoolOption = false
>> CompilerOracle: option Test.test intx MyIntxOption = -1
>> CompilerOracle: option Test.test uintx MyUintxOption = 1
>> CompilerOracle: option Test.test bool MyFlag = true
>> CompilerOracle: option Test.test double MyDoubleOption = '1.123000'
>> java version "1.9.0-ea"
>> Java(TM) SE Runtime Environment (build 1.9.0-ea-b33)
>> Java HotSpot(TM) 64-Bit Server VM (build 1.9.0-fastdebug-internal, mixed mode)
>>
>>
>> Webrev: http://cr.openjdk.java.net/~zmajo/8059847/webrev.00/
>>
>> Testing: JPRT
>>
>> Thank you and best regards,
>>
>>
>> Zoltan
>>
>


More information about the hotspot-compiler-dev mailing list