RFR(XS): 8145348: Make intrinsics flags diagnostic

[Rahul Raghavan]

Hi,

> -----Original Message-----
> From: Vladimir Kozlov > Sent: Tuesday, March 01, 2016 2:05 AM > To: hotspot-compiler-dev at openjdk.java.net
> 
> Looks good but we need to file CCC request since we changing product
> flags. You can push after it is approved.

Okay. Thank you Vladimir.

> 
> Thanks,
> Vladimir
> 
> On 2/29/16 10:12 AM, Rahul Raghavan wrote:
> > Hi,
> >
> > Please review the following patch for JDK-8145348.
> >
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8145348
> > Webrev: http://cr.openjdk.java.net/~rraghavan/8145348/webrev.00/
> >
> > - Identified flags which control intrinsics generation, from vmIntrinsics::is_disabled_by_flags().
> >
> > - Changed following flags from 'product' or 'develop' to 'diagnostic' type -
> >        [globals.hpp]
> >            UseGHASHIntrinsics
> >            InlineArrayCopy
> >            InlineObjectHash
> >            InlineNatives
> >            InlineMathNatives
> >            InlineClassNatives
> >            InlineThreadNatives
> >            InlineUnsafeOps
> >            UseAESIntrinsics
> >            UseAESCTRIntrinsics
> >            UseSHA1Intrinsics
> >            UseSHA256Intrinsics
> >            UseSHA512Intrinsics
> >            UseCRC32Intrinsics
> >            UseCRC32CIntrinsics
> >            UseAdler32Intrinsics
> >            UseVectorizedMismatchIntrinsic
> >
> >        [c1_globals.hpp]
> >            InlineNIOCheckIndex
> >
> >        [c2_globals.hpp]
> >            InlineReflectionGetCallerClass
> >            InlineObjectCopy
> >            SpecialStringCompareTo
> >            SpecialStringIndexOf
> >            SpecialStringEquals
> >            SpecialArraysEquals
> >            SpecialEncodeISOArray
> >            UseMathExactIntrinsics
> >            UseMultiplyToLenIntrinsic
> >            UseSquareToLenIntrinsic
> >            UseMulAddIntrinsic
> >            UseMontgomeryMultiplyIntrinsic
> >            UseMontgomerySquareIntrinsic
> >
> > - Added required -XX:+UnlockDiagnosticVMOptions to @run for following two tests using the intrinsic flags.
> >                  hotspot/test/compiler/intrinsics/muladd/TestMulAdd.java
> >                  hotspot/test/compiler/runtime/6859338/Test6859338.java
> >    (confirmed all other tests using any intrinsic flags got required -XX:+UnlockDiagnosticVMOptions also)
> >
> > - No issues with JPRT (-testset hotspot).
> > - Confirmed no issues, expected behavior with the change for small unit tests.
> >      (for debug/release VM with flags on/off, UnlockDiagnosticVMOptions usage combinations)
> >
> >
> > Thanks,
> > Rahul
> >