RFR(S): 8147844: new method j.l.Runtime.onSpinWait() and the corresponding x86 hotspot instrinsic
Ivan Krylov
ivan at azulsystems.com
Thu Mar 10 19:09:36 UTC 2016
On 10/03/2016 10:11, Christian Thalinger wrote:
> src/share/vm/runtime/vm_version.hpp:
>
> + // Does this compiler support intrinsification
> + // of java.lang.Thread.onSpinWait()
> + static bool supports_on_spin_wait() { return false; }
>
> This comment seems wrong.
Fixed with
// Does this CPU support spin wait instruction?
Thx.
>
>> On Mar 9, 2016, at 1:53 PM, Ivan Krylov <ivan at azulsystems.com> wrote:
>>
>> Paul, Indeed, thanks. I have modified the test.
>> I also made changes to reflect the fact that onSpinWait is now decided to be placed into j.l.Thread.
>>
>> Igor,
>> This is a new webrev: http://cr.openjdk.java.net/~ikrylov/8147844.hs.04/
>> This is the diff between previous and this patches (03 vs 04):
>> http://cr.openjdk.java.net/~ikrylov/8147844.hs.04/diff.txt
>>
>> Thanks,
>>
>> Ivan
>>
>> On 12/02/2016 06:01, Paul Sandoz wrote:
>>>> On 12 Feb 2016, at 00:55, Ivan Krylov <ivan at azulsystems.com> wrote:
>>>>
>>>> Hi Igor,
>>>>
>>>> Thanks both for your help and your reviews.
>>>> Here is a new version, tested on mac for c1 and c2:
>>>>
>>>> http://cr.openjdk.java.net/~ikrylov/8147844.hs.03
>>>>
>>> Now that support C1 is supported should the test be updated with C1 only execution?
>>>
>>> Paul.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160310/a783e05f/attachment.html>
More information about the hotspot-compiler-dev
mailing list