[9] RFR (S): 8152773: C2: LoadNode properties aren't preserved when converting between signed/unsigned variants
Vladimir Ivanov
vladimir.x.ivanov at oracle.com
Mon Mar 28 10:55:27 UTC 2016
Vladimir, John, thanks for the reviews.
On 3/25/16 10:28 PM, John Rose wrote:
> On Mar 25, 2016, at 11:51 AM, Vladimir Ivanov
> <vladimir.x.ivanov at oracle.com <mailto:vladimir.x.ivanov at oracle.com>> wrote:
>>
>> I think the motivation was to avoid massive change in all Load*Nodes.
>> LoadNode::make constructs a proper flavor and then sets
>> mismatched/unaligned flags.
>>
>>> I think they are separate booleans for the usual reason: They were
>>> introduced at different times.
>>
>> Do you think we should pack them?
>
> Yes, I think they should be packed and pushed into the constructor.
Filed JDK-8152843 [1].
Best regards,
Vladimir Ivanov
[1] https://bugs.openjdk.java.net/browse/JDK-8152843
More information about the hotspot-compiler-dev
mailing list