[9] RFR JDK-8152344: JVMCI test task: Unit tests for ConstantReflectionProvider

[Konstantin Shefov]

Yes, I can fix it.

So I need to replace "mx: TESTNG" to just “TESTNG", right?

-Konstantin
31 марта 2016 г. 3:32 пользователь "Christian Thalinger" <
christian.thalinger at oracle.com> написал:

>
> On Mar 30, 2016, at 4:34 AM, Doug Simon <doug.simon at oracle.com> wrote:
>
>
> On 25 Mar 2016, at 07:47, Christian Thalinger <
> christian.thalinger at oracle.com> wrote:
>
>
> On Mar 24, 2016, at 7:37 PM, Konstantin Shefov <
> konstantin.shefov at oracle.com> wrote:
>
> Christian
>
> I have fixed "mx checkstyle" errors.
> Then new webrev is: http://cr.openjdk.java.net/~kshefov/8152344/webrev.03/
>
>
> Looks good now.  Thanks for making all the changes I requested.  Reviewed.
>
> Since I don’t have time right now to add mx TestNG support could you add
> this to your patch?
>
> diff -r 1e385207d9f2 .mx.jvmci/suite.py
> --- a/.mx.jvmci/suite.py Fri Mar 18 15:54:47 2016 +0100
> +++ b/.mx.jvmci/suite.py Thu Mar 24 20:46:17 2016 -1000
> @@ -32,24 +32,9 @@ suite = {
>
>   "libraries" : {
>
> -    "HCFDIS" : {
> -      "urls" : ["https://lafo.ssw.uni-linz.ac.at/pub/hcfdis-3.jar"],
> -      "sha1" : "a71247c6ddb90aad4abf7c77e501acc60674ef57",
> -    },
> -
> -    "C1VISUALIZER_DIST" : {
> -      "urls" : ["
> https://java.net/downloads/c1visualizer/c1visualizer_2015-07-22.zip"],
> -      "sha1" : "7ead6b2f7ed4643ef4d3343a5562e3d3f39564ac",
> -    },
> -
> -    "JOL_INTERNALS" : {
> -      "urls" : ["
> https://lafo.ssw.uni-linz.ac.at/pub/truffle/jol/jol-internals.jar"],
> -      "sha1" : "508bcd26a4d7c4c44048990c6ea789a3b11a62dc",
> -    },
> -
> -    "BATIK" : {
> -      "sha1" : "122b87ca88e41a415cf8b523fd3d03b4325134a3",
> -      "urls" : ["
> https://lafo.ssw.uni-linz.ac.at/pub/graal-external-deps/batik-all-1.7.jar
> "],
> +    "TESTNG" : {
> +      "urls" : ["
> http://central.maven.org/maven2/org/testng/testng/6.9.10/testng-6.9.10.jar
> "],
> +      "sha1" : "6feb3e964aeb7097aff30c372aac3ec0f8d87ede",
>     },
>
>     # Stubs for classes introduced in JDK9 that allow compilation with a
> JDK8 javac and Eclipse.
> @@ -175,6 +160,18 @@ suite = {
>       "workingSets" : "JVMCI",
>     },
>
> +    "jdk.vm.ci.hotspot.test" : {
> +      "subDir" : "test/compiler/jvmci",
> +      "sourceDirs" : ["src"],
> +      "dependencies" : [
> +        "TESTNG",
> +        "jdk.vm.ci.hotspot",
> +      ],
>
>
> This got integrated incorrectly as a reference to “mx:TESTNG”:
>
>
> http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/file/cfb6c135aef4/.mx.jvmci/suite.py#l167
>
>
> Oops.  Thanks for catching this.  Konstantin, can you fix that?
>
>
> -Doug
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160331/bbac6ca5/attachment.html>