RFR: 8236701: [TESTBUG] compiler/loopopts/superword/Vec_MulAddS2I.java uses wrong flag -XX:-SuperWord

Fairoz Matte fairoz.matte at oracle.com
Mon Jan 13 15:53:08 UTC 2020


Hi Tobias,

Thanks for the review,
It does look like we still need "-XX:+IgnoreUnrecognizedVMOptions" flag.

Summary of the test case shows,  Superword support is only for limited platforms.

* @summary Add C2 x86 Superword support for VNNI VPDPWSSD Instruction
* @requires os.arch=="x86" | os.arch=="i386" | os.arch=="amd64" | os.arch=="x86_64"

I have updated copyright.

Thanks,
Fairoz

-----Original Message-----
From: Tobias Hartmann 
Sent: Monday, January 13, 2020 5:01 PM
To: Fairoz Matte <fairoz.matte at oracle.com>; Ioi Lam <ioi.lam at oracle.com>; hotspot-compiler-dev at openjdk.java.net
Subject: Re: RFR: 8236701: [TESTBUG] compiler/loopopts/superword/Vec_MulAddS2I.java uses wrong flag -XX:-SuperWord

Please also update the copyright.

Best regards,
Tobias

On 13.01.20 12:29, Tobias Hartmann wrote:
> Hi Fairoz,
> 
> On 13.01.20 09:29, Fairoz Matte wrote:
>> I was not sure why that option was added.
> 
> I think it's just because the author incorrectly assumed that some of 
> the flags sre only available in debug builds (which is not the case).
> 
>> Let me know, if that is ok to be removed, I will send the next webrev.
> 
> Yes, please do so. The change looks good to me.
> 
> Thanks,
> Tobias
> 


More information about the hotspot-compiler-dev mailing list