RFR(T) : 8252774 : remove jdk.test.lib.FileInstaller action from graalunit tests

Igor Ignatyev igor.ignatyev at oracle.com
Thu Sep 3 17:12:55 UTC 2020

> 341 lines changed: 0 ins; 240 del; 101 mod; 

Hi all,

could you please review this small and trivial clean up in test/hotspot/jtreg/compiler/graalunit?
from JBS:
> test/hotspot/jtreg/compiler/graalunit tests use jdk.test.lib.FileInstaller to copy ProblemList-graal.txt from test/hotspot/jtreg/ to the current working directory as ExcludeList.txt, and then run compiler.graalunit.common.GraalUnitTestLauncher w/ -exclude ExcludeList.txt. 
> j.t.l.FileInstaller actions aren't needed as c.g.c.GraalUnitTestLauncher interpeters `-exclude`'s value as path to file (as oppose to the file name in current directory), so we can use ${test.root}/ProblemList-graal.txt instead of ExcludeList.txt there.

the patch modifies generateTests.sh to use ${test.root}/ProblemList-graal.txt, cleans it up  (removes trailing spaces, empty @summary tag, and redundant explicit @build) and regenerates graalunit tests.

testing: test/hotspot/jtreg/compiler/graalunit on {linux,windows,macos}-x64
JBS: https://bugs.openjdk.java.net/browse/JDK-8252774
webrev: http://cr.openjdk.java.net/~iignatyev//8252774/webrev.00

-- Igor

More information about the hotspot-compiler-dev mailing list