RFR: 8261137: Optimization of Box nodes in uncommon_trap [v11]

Wang Huang whuang at openjdk.java.net
Fri Apr 2 01:36:34 UTC 2021


On Thu, 1 Apr 2021 17:43:02 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Creating node's dump string in separate method is complicated.
>> We can just use `false` in assert:
>> #ifdef ASSERT
>>   if (alloc != nullptr && !alloc->is_Allocate() && !alloc->as_CallStaticJava()->is_boxing_method()) {
>>     alloc->dump();
>>     assert(false, "unexpected call node for scalar replacement");
>>   }
>> #endif
>
> I did not see your latest changes before answering your question. You did exactly as I suggested. Good.

Thank you for your review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2401


More information about the hotspot-compiler-dev mailing list