RFR: 8265154: vinserti128 operand mix up for KNL platforms

Sandhya Viswanathan sviswanathan at openjdk.java.net
Wed Apr 14 05:06:05 UTC 2021


There is a bug in macro assembler in vinserti128 special handling for platforms like KNL that do not support AVX512VL.
 
The following:
   void vinserti128(XMMRegister dst, XMMRegister nds, XMMRegister src, uint8_t imm8) {
     if (UseAVX > 2 && VM_Version::supports_avx512novl()) {
       Assembler::vinserti32x4(dst, dst, src, imm8);
     }
     ...
  }
 
Should have been:
   void vinserti128(XMMRegister dst, XMMRegister nds, XMMRegister src, uint8_t imm8) {
     if (UseAVX > 2 && VM_Version::supports_avx512novl()) {
       Assembler::vinserti32x4(dst, nds, src, imm8);
     }
    ...
  }

Best Regards,
Sandhya

-------------

Commit messages:
 - 8265154: vinserti128 operand mix up for KNL platforms

Changes: https://git.openjdk.java.net/jdk/pull/3480/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3480&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8265154
  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3480.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3480/head:pull/3480

PR: https://git.openjdk.java.net/jdk/pull/3480


More information about the hotspot-compiler-dev mailing list