RFR: 8254129: IR Test Framework to support regex-based matching on the IR in JTreg compiler tests [v2]

Christian Hagedorn chagedorn at openjdk.java.net
Mon Apr 19 12:49:47 UTC 2021


On Thu, 15 Apr 2021 17:08:07 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Adjust whitelist
>
> test/lib/jdk/test/lib/hotspot/ir_framework/CompLevel.java line 62:
> 
>> 60:      *  </ul>
>> 61:      */
>> 62:     ANY(-2),
> 
> This will change (`-2` -> `-1`) after AOT is removed (8264805).

I'll change that as soon as it is integrated.

> test/lib/jdk/test/lib/hotspot/ir_framework/CompLevel.java line 63:
> 
>> 61:      */
>> 62:     ANY(-2),
>> 63:     /**
> 
> For completeness may be add value `NONE(0)` for Interpreter only case.

I agree that it makes sense for completeness. But I'm not sure if this is useful to have as `NONE` would not be supported by the framework for the time being and would just require additional handling, informing the user that this has no effect.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3508


More information about the hotspot-compiler-dev mailing list