RFR: 8265491: Math Signum optimization for x86 [v2]

[Marcus G K Williams]

On Tue, 20 Apr 2021 08:30:43 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Marcus G K Williams has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add os.arch=="i386" to signum jtreg
>>   
>>   Signed-off-by: Marcus G K Williams <marcus.williams at intel.com>
>
> src/hotspot/cpu/x86/x86.ad line 5786:
> 
>> 5784:   ins_encode %{
>> 5785:     Label exit;
>> 5786: 
> 
> Can you kindly move this into a macro assembly routine.

Do you mean `instruct signumF_reg`? Please explain your reasoning for the proposed move.

> src/hotspot/cpu/x86/x86.ad line 5806:
> 
>> 5804:     Label exit;
>> 5805: 
>> 5806:     __ ucomisd($dst$$XMMRegister, $zero$$XMMRegister);
> 
> Same as above, please create a macro assembly routine to capture it.

Do you mean `instruct signumD_reg`? Please explain your reasoning for the proposed move.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3581