RFR: 8265491: Math Signum optimization for x86 [v2]

Jatin Bhateja jbhateja at openjdk.java.net
Wed Apr 21 05:31:07 UTC 2021


On Tue, 20 Apr 2021 22:19:00 GMT, Marcus G K Williams <github.com+168222+mgkwill at openjdk.org> wrote:

>> src/hotspot/cpu/x86/x86.ad line 5786:
>> 
>>> 5784:   ins_encode %{
>>> 5785:     Label exit;
>>> 5786: 
>> 
>> Can you kindly move this into a macro assembly routine.
>
> Do you mean `instruct signumF_reg`? Please explain your reasoning for the proposed move.

I am referring to moving the instruction sequence into a macro assembly routine for better code sharing, one should be enough for both float and double type, please refer to following snippet for more detail.
https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/x86/x86.ad#L5672

-------------

PR: https://git.openjdk.java.net/jdk/pull/3581


More information about the hotspot-compiler-dev mailing list