RFR: 8265917: Different values computed by C2 and interpreter/C1 for Math.pow(x, 2.0) on x86_32 [v2]
Jie Fu
jiefu at openjdk.java.net
Tue Apr 27 11:09:06 UTC 2021
On Tue, 27 Apr 2021 09:28:38 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:
>> Jie Fu has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Optimize pow(x, 2.0) for x86_32
>
> src/hotspot/cpu/x86/macroAssembler_x86_pow.cpp line 2546:
>
>> 2544:
>> 2545: address static_const_table_pow = (address)_static_const_table_pow;
>> 2546: static double DOUBLE2 = 2.0;
>
> Constants in the 64-bit code and `_static_const_table_pow` above use `ATTRIBUTE_ALIGNED`. Should we add that for `DOUBLE2` as well?
Hi @TobiHartmann ,
Thanks for your review.
Yes, it seem better to be with ATTRIBUTE_ALIGNED.
Updated.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3677
More information about the hotspot-compiler-dev
mailing list