RFR: 8265711: C1: Intrinsify Class.getModifier method [v2]

[Tobias Hartmann]

On Tue, 27 Apr 2021 10:40:38 GMT, Yi Yang <yyang at openjdk.org> wrote:

>> Because is_intrinsic_support is not aware of the fact that getModifiers is an intrinsic method. So canonicalizer is even not applied.
>> 
>>> Also, your PR title is misleading. You are not simply canonicalizing Class.getModifier. You are intrinsifying it.
>> 
>> Yes, exactly. Changed.
>
> With the new IR test framework, these kinds of problem would never happen, we can do verification at IR level.

> Because is_intrinsic_support is not aware of the fact that getModifiers is an intrinsic method. So canonicalizer is even not applied.

But your first version (https://github.com/openjdk/jdk/pull/3616/commits/7f0be4e8a2cb4f6a9ef650b1b31c16f46716a257) already had the change to `is_intrinsic_supported`? Shouldn't that version have triggered test failures because it does not handle primitive types?

> With the new IR test framework, these kinds of problem would never happen, we can do verification at IR level.

Unfortunately not. The IR test framework currently only supports C2.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3616