RFR: 8266088: compiler/arguments/TestPrintOptoAssemblyLineNumbers test should user driver mode

Igor Ignatyev iignatyev at openjdk.java.net
Tue Apr 27 20:02:20 UTC 2021


Hi all,

could you please review this tiny patch for `TestPrintOptoAssemblyLineNumbers` test? 
from JBS:
> compiler/arguments/TestPrintOptoAssemblyLineNumbers class is a driver class that spawns a new JVM and validates its output, there is no need for the JVM which executes TestPrintOptoAssemblyLineNumbers to be run w/ all vm flags.

besides addressing this, the patch also removes `/compiler/patches` from `@library` as it's not needed and fixes code style here and there.

testing:
- [x] `compiler/arguments/TestPrintOptoAssemblyLineNumbers` on `{linux,windows,macosx}-x64-debug`

Thanks,
-- Igor

-------------

Commit messages:
 - one more space before { missed
 - use driver mode in TestPrintOptoAssemblyLineNumbers

Changes: https://git.openjdk.java.net/jdk/pull/3726/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3726&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8266088
  Stats: 12 lines in 1 file changed: 0 ins; 0 del; 12 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3726.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3726/head:pull/3726

PR: https://git.openjdk.java.net/jdk/pull/3726


More information about the hotspot-compiler-dev mailing list