RFR: 8266088: compiler/arguments/TestPrintOptoAssemblyLineNumbers test should user driver mode [v3]

Igor Ignatyev iignatyev at openjdk.java.net
Tue Apr 27 21:02:12 UTC 2021


On Tue, 27 Apr 2021 20:30:35 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:

>> Hi all,
>> 
>> could you please review this tiny patch for `TestPrintOptoAssemblyLineNumbers` test? 
>> from JBS:
>>> compiler/arguments/TestPrintOptoAssemblyLineNumbers class is a driver class that spawns a new JVM and validates its output, there is no need for the JVM which executes TestPrintOptoAssemblyLineNumbers to be run w/ all vm flags.
>> 
>> besides addressing this, the patch also removes `/compiler/patches` from `@library` as it's not needed and fixes code style here and there.
>> 
>> testing:
>> - [x] `compiler/arguments/TestPrintOptoAssemblyLineNumbers` on `{linux,windows,macosx}-x64-debug`
>> 
>> Thanks,
>> -- Igor
>
> Igor Ignatyev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixed line numbers

thanks, Vladimir.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3726


More information about the hotspot-compiler-dev mailing list