Integrated: 8266088: compiler/arguments/TestPrintOptoAssemblyLineNumbers test should user driver mode

Igor Ignatyev iignatyev at openjdk.java.net
Tue Apr 27 21:02:13 UTC 2021


On Tue, 27 Apr 2021 19:54:02 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:

> Hi all,
> 
> could you please review this tiny patch for `TestPrintOptoAssemblyLineNumbers` test? 
> from JBS:
>> compiler/arguments/TestPrintOptoAssemblyLineNumbers class is a driver class that spawns a new JVM and validates its output, there is no need for the JVM which executes TestPrintOptoAssemblyLineNumbers to be run w/ all vm flags.
> 
> besides addressing this, the patch also removes `/compiler/patches` from `@library` as it's not needed and fixes code style here and there.
> 
> testing:
> - [x] `compiler/arguments/TestPrintOptoAssemblyLineNumbers` on `{linux,windows,macosx}-x64-debug`
> 
> Thanks,
> -- Igor

This pull request has now been integrated.

Changeset: 7f4a9f68
Author:    Igor Ignatyev <iignatyev at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/7f4a9f68bfd6fd002f79ac989155550db0bcdd20
Stats:     19 lines in 1 file changed: 4 ins; 1 del; 14 mod

8266088: compiler/arguments/TestPrintOptoAssemblyLineNumbers test should user driver mode

Reviewed-by: kvn

-------------

PR: https://git.openjdk.java.net/jdk/pull/3726


More information about the hotspot-compiler-dev mailing list