<html>
  <head>
    <meta http-equiv="content-type" content="text/html; charset=UTF-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    Hi,<br>
    <br>
    please review the new version of the following patch that adds
    support for multiple code heaps to the code cache.<br>
    <br>
    Bug:
    <meta http-equiv="content-type" content="text/html; charset=UTF-8">
    <a href="https://bugs.openjdk.java.net/browse/JDK-8015774">https://bugs.openjdk.java.net/browse/JDK-8015774</a><br>
    Webrev: <span><a moz-do-not-send="true"
        href="http://cr.openjdk.java.net/%7Eanoll/8015774/webrev.03/">http://cr.openjdk.java.net/~anoll/8015774/webrev.04/</a><br>
      <br>
      <b>Short description:</b><br>
      This change implements support for multiple code heaps in the code
      cache. The interface of the code cache was changed accordingly and
      references from other components of the VM were adapted. This
      includes the indirect references from:<br>
      - the Serviceability Agent: vmStructs and the Java code cache
      interface (sun.jvm.hotspot.code.CodeCache)<br>
      - the dtrace ustack helper script (jhelper.d)<br>
      - the pstack support library libjvm_db.c<br>
      <br>
      Currently the code cache contains the following three code heaps
      each of which contains CodeBlobs of a specific type:<br>
      - Non-Profiled methods: nmethods that are not profiled and native
      methods<br>
      - Profiled methods: nmethods that are profiled<br>
      - Non-methods: Non-methods like buffers and adapters<br>
      <br>
      By default the non-method code heap uses 3 MB plus additional
      space for the compiler buffers that is dependent on the number of
      compiler threads (see CodeCache::initialize_heaps). The remaining
      code cache space is distributed equally among the non-profiled and
      the profiled code heaps.<br>
    </span><b><br>
    </b><b>Tested:</b><br>
    JPRT, SPECjvm2008, SPECjbb2005, SPECjbb2013, Octane + Nashorn<br>
    <br>
    Thanks,<br>
    Tobias<br>
    <div class="moz-forward-container"><br>
      <br>
      -------- Original Message --------
      <table class="moz-email-headers-table" border="0" cellpadding="0"
        cellspacing="0">
        <tbody>
          <tr>
            <th align="RIGHT" nowrap="nowrap" valign="BASELINE">Subject:
            </th>
            <td>Re: RFR (L): 8015774: Add support for multiple code
              heaps</td>
          </tr>
          <tr>
            <th align="RIGHT" nowrap="nowrap" valign="BASELINE">Date: </th>
            <td>Mon, 21 Oct 2013 17:47:48 +0200</td>
          </tr>
          <tr>
            <th align="RIGHT" nowrap="nowrap" valign="BASELINE">From: </th>
            <td>Albert Noll <a class="moz-txt-link-rfc2396E"
                href="mailto:albert.noll@oracle.com"><albert.noll@oracle.com></a></td>
          </tr>
          <tr>
            <th align="RIGHT" nowrap="nowrap" valign="BASELINE">To: </th>
            <td>Azeem Jiva <a class="moz-txt-link-rfc2396E"
                href="mailto:azeem.jiva@oracle.com"><azeem.jiva@oracle.com></a></td>
          </tr>
        </tbody>
      </table>
      <br>
      <br>
      <meta http-equiv="content-type" content="text/html; charset=UTF-8">
      <div>That is fine. As we realized the last two weeks, there is
        more work to be done to make multiple code heaps work
        effectively.</div>
      <div><br>
      </div>
      <div>Albert<br>
        <br>
        Von meinem iPhone gesendet</div>
      <div><br>
        Am 21.10.2013 um 17:36 schrieb Azeem Jiva <<a
          moz-do-not-send="true" href="mailto:azeem.jiva@oracle.com">azeem.jiva@oracle.com</a>>:<br>
        <br>
      </div>
      <blockquote type="cite">
        <div>
          <meta http-equiv="Content-Type" content="text/html;
            charset=UTF-8">
          I still think we should hold off for JDK8u20
          <div><br>
            <div>
              <div style="color: rgb(0, 0, 0); font-family: Helvetica;
                font-size: medium; font-style: normal; font-variant:
                normal; font-weight: normal; letter-spacing: normal;
                line-height: normal; orphans: 2; text-align:
                -webkit-auto; text-indent: 0px; text-transform: none;
                white-space: normal; widows: 2; word-spacing: 0px;
                -webkit-text-size-adjust: auto;
                -webkit-text-stroke-width: 0px; word-wrap: break-word;
                -webkit-nbsp-mode: space; -webkit-line-break:
                after-white-space; ">
                <div>--</div>
                <div>Azeem Jiva</div>
                <div>@javawithjiva</div>
              </div>
            </div>
            <br>
            <div>
              <div>On Oct 21, 2013, at 8:33 AM, Albert Noll <<a
                  moz-do-not-send="true"
                  href="mailto:albert.noll@oracle.com">albert.noll@oracle.com</a>>



                wrote:</div>
              <br class="Apple-interchange-newline">
              <blockquote type="cite">
                <meta http-equiv="content-type" content="text/html;
                  charset=UTF-8">
                <div dir="auto"><br>
                  <div> Von meinem iPhone gesendet</div>
                  <div><br>
                    Anfang der weitergeleiteten E‑Mail:<br>
                    <br>
                  </div>
                  <blockquote type="cite"><b>Von:</b> Vladimir Kozlov
                    <<a moz-do-not-send="true"
                      href="mailto:vladimir.kozlov@oracle.com">vladimir.kozlov@oracle.com</a>><br>
                    <b>Datum:</b> 11. Oktober 2013 19:38:07 MESZ<br>
                    <b>An:</b> <a moz-do-not-send="true"
                      href="mailto:hotspot-compiler-dev@openjdk.java.net">hotspot-compiler-dev@openjdk.java.net</a><br>
                    <b>Betreff:</b> <b>Re: RFR (L): 8015774: Add
                      support for multiple code heaps</b><br>
                    <br>
                  </blockquote>
                  <blockquote type="cite"><span>This looks acceptable.</span><br>
                    <span></span><br>
                    <span>Thanks,</span><br>
                    <span>Vladimir</span><br>
                  </blockquote>
                </div>
              </blockquote>
            </div>
          </div>
        </div>
      </blockquote>
    </div>
  </body>
</html>