Request for reviews (M): 7191102: nightly failures after JSR 292 lazy method handle update (round 3)
Vladimir Kozlov
vladimir.kozlov at oracle.com
Wed Aug 15 11:46:02 PDT 2012
Looks good to me.
Thanks,
Vladimir
Christian Thalinger wrote:
> On Aug 13, 2012, at 5:52 PM, John Rose <john.r.rose at oracle.com> wrote:
>
>> On Aug 13, 2012, at 4:03 PM, Christian Thalinger wrote:
>>
>>> http://cr.openjdk.java.net/~twisti/7191102
>>>
>>> 7191102: nightly failures after JSR 292 lazy method handle update (round 3)
>>> Reviewed-by:
>>>
>>> Another round of fixes for bugs found during nightly testing.
>> The "naked constants" -1, -2, -3 related to the arity checks were hard to understand, so I pushed a change here to document them:
>> http://hg.openjdk.java.net/mlvm/mlvm/jdk/rev/17b551da7237
>
> I removed these lines in:
>
> src/share/classes/java/lang/invoke/MethodHandleImpl.java:
>
> + //outArgs[0] = target;
> + //names[OUT_CALL] = new Name(MethodHandles.basicInvoker(dstType.basicType()), outArgs);
>
> and updated the webrev.
>
> Otherwise the changes look good.
>
> -- Chris
>
>> — John
>
More information about the hotspot-dev
mailing list