RFR (S): 7192916: Hotspot development launcher should use DYLD_LIBRARY_PATH on OS X

Nils Loodin nils.loodin at oracle.com
Tue Aug 21 06:17:39 PDT 2012


On 2012-08-21 15:07, Staffan Larsen wrote:
> Please review this change to the HotSpot development launcher. The development launcher (called 'hotspot' in the build output folder) should use DYLD_LIBRARY_PATH instead of LD_LIBRARY_PATH on OS X.
>
> http://cr.openjdk.java.net/~sla/7192916/webrev.00/
>
> Thanks,
> /Staffan
There should be some indentation after the first added if statement.
Otherwise looks ok.

Although, since the logic is very similar, perhaps it should be a common 
'logic bloc', and the 'if darwin' statement only set's if it's 
LD_LIBRARY_PATH or DYLD_LIBRARY_PATH that gets exported?



/Nils Loodin


More information about the hotspot-dev mailing list